[go-nuts] net/smtp Quit should prolly have a better return value

Hello currently I struggled to keep my webserver up after sending a mail,
that was caused since I had something like that in my code:

if err = c.Quit(); err != nil {
log.Fatal(err)
}

I kept searching and if read the Docs so carefully.. (
https://golang.org/pkg/net/smtp/#Client.Quit)

However Quit() doesn't return just an error as it seems...

We should prolly fix that to standard go like (string, error). Since the
250 Ok Message of the Client will also be an error, which is of course not
an error and it will shut your program down, if you check for an error..
https://github.com/golang/go/blob/master/src/net/smtp/smtp.go#L373-L383

--
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to golang-nuts...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/d/optout.

Hi Christian,

Why would the 250 OK message from the client be an error?

I'm reading the code, and I don't see anything but actual errors being
returned by Quit.

What am I missing?

Andrew


On 30 June 2015 at 01:27, Christian Schmitt <c.sc...@briefdomain.de>
wrote:

--

I used it with AWS SES and It returned the following:

14:17:30 app | 2015/06/30 14:17:30 Quit Message: 250 Ok
0000014e44669548-f3afa74a-3a31-41ea-b2c6-f7a61b9f63e9-000000

Currently this is my code:

https://gist.github.com/schmitch/1571d2c15864202830ab

I'm not sure but 250 Ok doesn't seems to be an error...


Am Dienstag, 30. Juni 2015 14:14:37 UTC+2 schrieb Andrew Gerrand:
Hello currently I struggled to keep my webserver up after sending a mail,
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to golang-nuts...@googlegroups.com <javascript:>.
For more options, visit https://groups.google.com/d/optout.

I used it with AWS SES and It returned the following:

14:17:30 app | 2015/06/30 14:17:30 Quit Message: 250 Ok
0000014e44669548-f3afa74a-3a31-41ea-b2c6-f7a61b9f63e9-000000

Currently this is my code:

https://gist.github.com/schmitch/1571d2c15864202830ab

I'm not sure but 250 Ok doesn't seems to be an error...


Am Dienstag, 30. Juni 2015 14:14:37 UTC+2 schrieb Andrew Gerrand:
Hello currently I struggled to keep my webserver up after sending a mail,
You received this message because you are subscribed to the Google Groups
"golang-nuts" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to golang-nuts+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.