FAQ
Change e6d351126475 broke the openbsd-amd64-gce56 build:
http://build.golang.org/log/9e8ba790803bd249265c87aed1016299d717174e

Revert "liblink, cmd/ld, runtime: remove stackguard1"

This reverts commit ab0535ae3fb45ba734d47542cc4845f27f708d1b.

I think it will remain useful to distinguish code that must
run on a system stack from code that can run on either stack,
even if that distinction is no
longer based on the implementation language.

That is, I expect to add a //go:systemstack comment that,
in terms of the old implementation, tells the compiler,
to pretend this function was written in C.

Change-Id: I33d2ebb2f99ae

https://golang.org/change/e6d351126475

$ tail -200 < log
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2081d1fe0
sp=0xc2081d1fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d1fe8 sp=0xc2081d1fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44675 [runnable]:
runtime_test.func·057()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:267 fp=0xc2080b5fe0
sp=0xc2080b5fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b5fe8 sp=0xc2080b5fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:274 +0x3a5

goroutine 44682 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2080b17e0
sp=0xc2080b17d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b17e8 sp=0xc2080b17e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44673 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2081d6fe0
sp=0xc2081d6fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d6fe8 sp=0xc2081d6fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44676 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2081d07e0
sp=0xc2081d07d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d07e8 sp=0xc2081d07e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44664 [runnable]:
runtime.mapiternext(0xc2081be788)
  /tmp/buildlet-scatch561838802/src/runtime/hashmap.go:601 fp=0xc2081be768
sp=0xc2081be760
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:256 +0x96
fp=0xc2081be7e0 sp=0xc2081be768
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081be7e8 sp=0xc2081be7e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44670 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2081d57e0
sp=0xc2081d57d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d57e8 sp=0xc2081d57e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44674 [runnable]:
runtime_test.func·056()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:259 fp=0xc2080b57e0
sp=0xc2080b57d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b57e8 sp=0xc2080b57e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:264 +0x2fa

goroutine 44685 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2080b2fe0
sp=0xc2080b2fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b2fe8 sp=0xc2080b2fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44698 [runnable]:
runtime_test.func·056()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:259 fp=0xc2080b47e0
sp=0xc2080b47d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b47e8 sp=0xc2080b47e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:264 +0x2fa

goroutine 44667 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2081d3fe0
sp=0xc2081d3fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d3fe8 sp=0xc2081d3fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44671 [runnable]:
runtime_test.func·056()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:259 fp=0xc2081d5fe0
sp=0xc2081d5fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d5fe8 sp=0xc2081d5fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:264 +0x2fa

goroutine 44694 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc20815f7e0
sp=0xc20815f7d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc20815f7e8 sp=0xc20815f7e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44678 [runnable]:
runtime_test.func·057()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:267 fp=0xc2081d17e0
sp=0xc2081d17d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d17e8 sp=0xc2081d17e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:274 +0x3a5

goroutine 44665 [runnable]:
runtime_test.func·056()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:259 fp=0xc2081befe0
sp=0xc2081befd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081befe8 sp=0xc2081befe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:264 +0x2fa

goroutine 44695 [runnable]:
runtime_test.func·056()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:259 fp=0xc20815d7e0
sp=0xc20815d7d8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc20815d7e8 sp=0xc20815d7e0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:264 +0x2fa

goroutine 44691 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc20801afe0
sp=0xc20801afd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc20801afe8 sp=0xc20801afe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44697 [runnable]:
runtime_test.func·055()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:254 fp=0xc2080b3fe0
sp=0xc2080b3fd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2080b3fe8 sp=0xc2080b3fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:258 +0x24c

goroutine 44681 [semacquire]:
runtime.gopark(0x699900, 0x75d2e0, 0x63d7b0, 0xa)
  /tmp/buildlet-scatch561838802/src/runtime/proc.go:151 +0x108
fp=0xc2081d2c08 sp=0xc2081d2bd8
runtime.goparkunlock(0x75d2e0, 0x63d7b0, 0xa)
  /tmp/buildlet-scatch561838802/src/runtime/proc.go:157 +0x48
fp=0xc2081d2c30 sp=0xc2081d2c08
runtime.semacquire(0x73f034, 0x591b00)
  /tmp/buildlet-scatch561838802/src/runtime/sema.go:100 +0x22f
fp=0xc2081d2c68 sp=0xc2081d2c30
runtime.gogc(0xc200000000)
  /tmp/buildlet-scatch561838802/src/runtime/malloc.go:465 +0x9d
fp=0xc2081d2ce0 sp=0xc2081d2c68
runtime.mallocgc(0x50, 0x60c120, 0x0, 0x591b00)
  /tmp/buildlet-scatch561838802/src/runtime/malloc.go:345 +0x3e5
fp=0xc2081d2df0 sp=0xc2081d2ce0
runtime.newobject(0x60c120, 0x591b00)
  /tmp/buildlet-scatch561838802/src/runtime/malloc.go:387 +0x49
fp=0xc2081d2e18 sp=0xc2081d2df0
reflect.mapiterinit(0x590400, 0xc20800a480, 0x15)
  /tmp/buildlet-scatch561838802/src/runtime/hashmap.go:939 +0x2a
fp=0xc2081d2e40 sp=0xc2081d2e18
reflect.Value.MapKeys(0x590400, 0xc20800a480, 0x15, 0x0, 0x0, 0x0)
  /tmp/buildlet-scatch561838802/src/reflect/value.go:1043 +0xf9
fp=0xc2081d2ee8 sp=0xc2081d2e40
runtime_test.func·057()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:270 +0xb3
fp=0xc2081d2fe0 sp=0xc2081d2ee8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc2081d2fe8 sp=0xc2081d2fe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:274 +0x3a5

goroutine 44693 [runnable]:
runtime_test.func·057()
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:267 fp=0xc20815dfe0
sp=0xc20815dfd8
runtime.goexit()
  /tmp/buildlet-scatch561838802/src/runtime/asm_amd64.s:2389 +0x1
fp=0xc20815dfe8 sp=0xc20815dfe0
created by runtime_test.testConcurrentReadsAfterGrowth
  /tmp/buildlet-scatch561838802/src/runtime/map_test.go:274 +0x3a5
FAIL runtime 37.868s
? runtime/cgo [no test files]
ok runtime/debug 0.528s
ok runtime/pprof 10.299s
? runtime/race [no test files]
ok sort 0.720s
ok strconv 0.351s
ok strings 0.590s
ok sync 0.347s
ok sync/atomic 0.326s
ok syscall 1.024s
ok testing 1.293s
? testing/iotest [no test files]
ok testing/quick 0.198s
ok text/scanner 0.096s
ok text/tabwriter 0.146s
ok text/template 0.535s
ok text/template/parse 0.345s
ok time 4.650s
ok unicode 0.786s
ok unicode/utf16 0.118s
ok unicode/utf8 0.500s
? unsafe [no test files]

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 5, '15 at 4:36p
activeJan 5, '15 at 4:36p
posts1
users1
websitegolang.org

1 user in discussion

Builder: 1 post

People

Translate

site design / logo © 2021 Grokbase