FAQ
Change 19f2bd8c2e00 broke the nacl-arm-cheney build:
http://build.golang.org/log/6aa10b15f251a8442954aefabc69b07544436e81

cmd/go: be more careful when linking a test exe with gccgo

Previously, we ended up passing two compiled objects for the package
being tested when linking the test executable. Somewhat by luck, this
worked most of the time but occasionally it did not. This changes the
linking code to not pass two objects for the same ImportPath and to
always pass the object for the test version of the package and removes
some unecessary nil checks.

Change-Id: I7bbd3fc708f14672ee2cc6aed3397421fceb8a38
Reviewed

http://code.google.com/p/go/source/detail?r=19f2bd8c2e00

$ tail -200 < log
cmd/pprof/internal/report
cmd/pprof/internal/symbolizer
cmd/pprof/internal/symbolz
archive/zip
cmd/go
cmd/pprof/internal/fetch
compress/lzw
cmd/pprof/internal/commands
compress/zlib
database/sql/driver
encoding/csv
cmd/pprof/internal/driver
database/sql
encoding/gob
expvar
cmd/pprof
image/draw
image/gif
image/jpeg
image/png
net/http/cgi
net/http/cookiejar
net/http/httptest
net/http/fcgi
net/http/httputil
net/http/pprof
net/mail
net/rpc
net/smtp
os/user
runtime/debug
testing
net/rpc/jsonrpc
testing/iotest
testing/quick
text/scanner

##### Testing packages.
ok cmd/addr2line 0.468s
? cmd/cgo [no test files]
ok cmd/fix 0.563s
ok cmd/go 3.958s
ok cmd/gofmt 4.344s
ok cmd/link 3.898s
ok cmd/nm 0.439s
ok cmd/objdump 0.426s
ok cmd/pack 3.588s
? cmd/pprof [no test files]
? cmd/yacc [no test files]
ok archive/tar 3.395s
ok archive/zip 8.859s
ok bufio 2.875s
ok bytes 1.400s
ok cmd/internal/goobj 0.380s
? cmd/internal/objfile [no test files]
? cmd/pprof/internal/commands [no test files]
? cmd/pprof/internal/driver [no test files]
? cmd/pprof/internal/fetch [no test files]
? cmd/pprof/internal/plugin [no test files]
? cmd/pprof/internal/profile [no test files]
? cmd/pprof/internal/report [no test files]
? cmd/pprof/internal/svg [no test files]
? cmd/pprof/internal/symbolizer [no test files]
? cmd/pprof/internal/symbolz [no test files]
? cmd/pprof/internal/tempfile [no test files]
ok compress/bzip2 1.213s
ok compress/flate 9.736s
ok compress/gzip 3.436s
ok compress/lzw 3.977s
ok compress/zlib 15.498s
ok container/heap 0.372s
ok container/list 0.373s
ok container/ring 0.411s
? crypto [no test files]
ok crypto/aes 0.460s
ok crypto/cipher 3.422s
ok crypto/des 0.510s
ok crypto/dsa 3.305s
ok crypto/ecdsa 4.055s
ok crypto/elliptic 3.867s
ok crypto/hmac 0.396s
ok crypto/md5 4.327s
ok crypto/rand 3.450s
ok crypto/rc4 1.961s
ok crypto/rsa 5.946s
ok crypto/sha1 3.556s
ok crypto/sha256 0.387s
ok crypto/sha512 0.398s
ok crypto/subtle 0.463s
ok crypto/tls 18.728s
ok crypto/x509 12.757s
? crypto/x509/pkix [no test files]
ok database/sql 0.819s
ok database/sql/driver 0.443s
ok debug/dwarf 3.521s
ok debug/elf 3.432s
ok debug/gosym 0.376s
ok debug/macho 3.296s
ok debug/pe 3.384s
ok debug/plan9obj 3.499s
? encoding [no test files]
ok encoding/ascii85 0.488s
ok encoding/asn1 3.431s
ok encoding/base32 0.440s
ok encoding/base64 0.382s
ok encoding/binary 0.354s
ok encoding/csv 0.453s
ok encoding/gob 4.279s
ok encoding/hex 0.380s
ok encoding/json 2.121s
ok encoding/pem 0.409s
ok encoding/xml 3.499s
ok errors 0.408s
ok expvar 0.543s
ok flag 0.362s
ok fmt 0.796s
ok go/ast 0.482s
ok go/build 3.548s
ok go/doc 4.211s
ok go/format 3.978s
ok go/parser 3.811s
ok go/printer 7.121s
ok go/scanner 0.385s
ok go/token 0.824s
? hash [no test files]
ok hash/adler32 0.453s
ok hash/crc32 0.347s
ok hash/crc64 0.424s
ok hash/fnv 0.371s
ok html 0.381s
ok html/template 4.431s
ok image 4.255s
ok image/color 0.390s
? image/color/palette [no test files]
ok image/draw 4.132s
ok image/gif 4.214s
ok image/jpeg 4.664s
ok image/png 3.915s
ok index/suffixarray 0.424s
ok io 0.574s
ok io/ioutil 3.317s
ok log 3.348s
ok math 0.447s
ok math/big 6.479s
ok math/cmplx 0.421s
ok math/rand 3.385s
ok mime 3.431s
ok mime/internal/quotedprintable 12.729s
ok mime/multipart 4.008s
ok net 6.134s
ok net/http 20.829s
ok net/http/cgi 3.560s
ok net/http/cookiejar 0.542s
ok net/http/fcgi 0.585s
ok net/http/httptest 0.544s
ok net/http/httputil 0.623s
ok net/http/internal 0.402s
? net/http/pprof [no test files]
ok net/mail 3.451s
ok net/rpc 3.932s
ok net/rpc/jsonrpc 0.651s
ok net/smtp 3.988s
ok net/textproto 0.355s
ok net/url 0.536s
ok os 3.519s
ok os/exec 3.528s
ok os/signal 0.353s
ok os/user 0.342s
ok path 0.347s
ok path/filepath 3.543s
ok reflect 1.313s
ok regexp 4.470s
ok regexp/syntax 4.102s

** Signal 3 from trusted code: pc=76e99f24
*** Test killed with quit: ran too long (7m0s).
FAIL runtime 420.029s
ok runtime/debug 3.533s
ok runtime/pprof 0.589s
? runtime/race [no test files]
ok sort 1.000s
ok strconv 6.375s
ok strings 1.198s
ok sync 0.956s
ok sync/atomic 1.865s
ok syscall 0.446s
ok testing 3.286s
? testing/iotest [no test files]
ok testing/quick 0.783s
ok text/scanner 0.436s
ok text/tabwriter 0.515s
ok text/template 4.085s
ok text/template/parse 0.605s
ok time 11.837s
ok unicode 0.426s
ok unicode/utf16 0.333s
ok unicode/utf8 0.344s
? unsafe [no test files]
Build complete, duration 18m55.187773146s. Result: error: exit status 1

--
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 4, '15 at 11:07p
activeJan 4, '15 at 11:07p
posts1
users1
websitegolang.org

1 user in discussion

Builder: 1 post

People

Translate

site design / logo © 2022 Grokbase