FAQ
Hi,

I've sent https://codereview.appspot.com/50420043/
which addresses https://code.google.com/p/go/issues/detail?id=6809

It extends goroutine stacks with information how long the goroutine is
blocked, e.g.:

goroutine 4 [sleep for 3 min]:
time.Sleep(0x34630b8a000)
         src/pkg/runtime/time.goc:31 +0x31
main.func·002()
         block.go:16 +0x2c
created by main.main
         block.go:17 +0x33

Now that all CLs are not CCed to golang-dev, I post it here so that
all interested parties have a change to comment on it before it's
submitted.
Any comments on the output format -- appending " for 3 min" to status?

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Josh Bleecher Snyder at Jan 13, 2014 at 2:50 pm
    Any comments on the output format -- appending " for 3 min" to status?
    SGTM.

    Two minor thoughts:

    Perhaps " for about 3 min", to emphasize the imprecision of the measurement?

    Using time.Duration format seems like an obvious choice, but may not
    be worth the code here.

    -josh

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dmitry Vyukov at Jan 13, 2014 at 3:16 pm

    On Mon, Jan 13, 2014 at 6:50 PM, Josh Bleecher Snyder wrote:
    Any comments on the output format -- appending " for 3 min" to status?
    SGTM.

    Two minor thoughts:

    Perhaps " for about 3 min", to emphasize the imprecision of the measurement?
    How strongly do you feel about it?
    I wanted to keep it short. And a user does not have means to prove the
    output is incorrect (you don't know when it actually become blocked).

    Using time.Duration format seems like an obvious choice, yes
    but may not be worth the code here.
    and yes

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Andrey mirtchovski at Jan 13, 2014 at 4:06 pm
    how about "for ~3 minutes"?
    On Mon, Jan 13, 2014 at 8:16 AM, Dmitry Vyukov wrote:
    On Mon, Jan 13, 2014 at 6:50 PM, Josh Bleecher Snyder
    wrote:
    Any comments on the output format -- appending " for 3 min" to status?
    SGTM.

    Two minor thoughts:

    Perhaps " for about 3 min", to emphasize the imprecision of the measurement?
    How strongly do you feel about it?
    I wanted to keep it short. And a user does not have means to prove the
    output is incorrect (you don't know when it actually become blocked).

    Using time.Duration format seems like an obvious choice, yes
    but may not be worth the code here.
    and yes

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Josh Bleecher Snyder at Jan 13, 2014 at 7:06 pm

    Perhaps " for about 3 min", to emphasize the imprecision of the measurement?
    How strongly do you feel about it?
    Not strongly.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJan 13, '14 at 7:45a
activeJan 13, '14 at 7:06p
posts5
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase