Change f7453c243cb9 broke the windows-386-ec2 build:

runtime: handle gdb breakpoint in x86 traceback

This lets stack splits work correctly when running under gdb
when gdb has inserted a breakpoint somewhere on the call

Fixes issue 6834.

R=golang-codereviews, minux.ma


$ tail -200 < log

# Testing packages.
? cmd/cgo [no test files]
ok cmd/fix 0.265s
ok cmd/go 0.067s
ok cmd/gofmt 0.519s
? cmd/nm [no test files]
? cmd/yacc [no test files]
ok archive/tar 0.030s
ok archive/zip 1.242s
ok bufio 0.635s
ok bytes 0.394s
ok compress/bzip2 0.396s
ok compress/flate 1.875s
ok compress/gzip 0.231s
ok compress/lzw 0.295s
ok compress/zlib 3.497s
ok container/heap 0.218s
ok container/list 0.170s
ok container/ring 0.205s
? crypto [no test files]
ok crypto/aes 0.050s
ok crypto/cipher 0.337s
ok crypto/des 0.070s
ok crypto/dsa 0.171s
ok crypto/ecdsa 0.409s
ok crypto/elliptic 0.397s
ok crypto/hmac 0.128s
ok crypto/md5 0.219s
ok crypto/rand 0.187s
ok crypto/rc4 0.421s
ok crypto/rsa 0.952s
ok crypto/sha1 0.162s
ok crypto/sha256 0.157s
ok crypto/sha512 0.190s
ok crypto/subtle 0.193s
ok crypto/tls 6.213s
ok crypto/x509 4.758s
? crypto/x509/pkix [no test files]
ok database/sql 0.219s
ok database/sql/driver 0.199s
ok debug/dwarf 0.243s
ok debug/elf 0.071s
ok debug/goobj 0.204s
ok debug/gosym 0.161s
ok debug/macho 0.250s
ok debug/pe 0.061s
? encoding [no test files]
ok encoding/ascii85 0.217s
ok encoding/asn1 0.208s
ok encoding/base32 0.222s
ok encoding/base64 0.136s
ok encoding/binary 0.049s
ok encoding/csv 0.212s
ok encoding/gob 0.404s
ok encoding/hex 0.025s
ok encoding/json 0.475s
ok encoding/pem 0.216s
ok encoding/xml 0.233s
ok errors 0.140s
ok expvar 0.088s
ok flag 0.207s
ok fmt 0.336s
ok go/ast 0.207s
ok go/build 0.977s
ok go/doc 0.182s
ok go/format 0.201s
ok go/parser 0.364s
ok go/printer 0.866s
ok go/scanner 0.193s
ok go/token 0.257s
? hash [no test files]
ok hash/adler32 0.216s
ok hash/crc32 0.037s
ok hash/crc64 0.024s
ok hash/fnv 0.025s
ok html 0.232s
ok html/template 0.360s
ok image 0.474s
ok image/color 0.058s
? image/color/palette [no test files]
ok image/draw 0.384s
ok image/gif 0.283s
ok image/jpeg 0.577s
ok image/png 0.297s
ok index/suffixarray 0.189s
ok io 0.174s
ok io/ioutil 0.132s
ok log 0.229s
? log/syslog [no test files]
ok math 0.143s
ok math/big 0.964s
ok math/cmplx 0.187s
ok math/rand 1.157s
ok mime 0.074s
ok mime/multipart 0.780s
ok net 23.800s
ok net/http 6.326s
ok net/http/cgi 0.215s
ok net/http/cookiejar 0.089s
ok net/http/fcgi 0.291s
ok net/http/httptest 0.345s
ok net/http/httputil 0.317s
? net/http/pprof [no test files]
ok net/mail 0.029s
ok net/rpc 0.319s
ok net/rpc/jsonrpc 0.435s
ok net/smtp 0.235s
ok net/textproto 0.153s
ok net/url 0.143s
ok os 1.168s
ok os/exec 5.532s
ok os/signal 2.150s
ok os/user 0.178s
ok path 0.181s
ok path/filepath 0.783s
ok reflect 0.611s
ok regexp 0.435s
ok regexp/syntax 2.394s
ok runtime 38.257s
? runtime/cgo [no test files]
ok runtime/debug 0.228s
ok runtime/pprof 12.006s
? runtime/race [no test files]
ok sort 0.527s
ok strconv 1.334s
ok strings 0.370s
ok sync 0.350s
ok sync/atomic 0.240s
ok syscall 0.060s
ok testing 0.157s
? testing/iotest [no test files]
ok testing/quick 0.300s
ok text/scanner 0.141s
ok text/tabwriter 0.056s
ok text/template 0.354s
ok text/template/parse 0.200s
ok time 3.586s
ok unicode 0.183s
ok unicode/utf16 0.205s
ok unicode/utf8 0.204s
? unsafe [no test files]

# runtime -cpu=1,2,4
ok runtime 110.075s

# sync -cpu=10
ok sync 0.287s

# ..\misc\goplay

# ..\test\bench\go1
ok _/c_/gobuilder/windows-386-ec2-f7453c243cb9/go/test/bench/go1 8.537s

# ..\misc\cgo\life

# ..\misc\cgo\stdio

# ..\misc\cgo\test
ok _/c_/gobuilder/windows-386-ec2-f7453c243cb9/go/misc/cgo/test 1.552s

# ..\misc\cgo\testso

# ..\doc\progs

# ..\test

# Checking API compatibility.
Error running API checker: exit status 1
panic: invalid memory address or nil pointer dereference
fatal error: panic during malloc
[signal 0xc0000005 code=0x0 addr=0x1 pc=0x423d72]

goroutine 1 [running]:
+0x67 fp=0x19e2488
+0x52 fp=0x19e249c

+0xb4 fp=0x19e24a8
runtime.mallocgc(0x20, 0x593500, 0x0)
+0x412 fp=0x19e24e4
cnew(0x593500, 0x1, 0x0)

+0xa9 fp=0x19e24f4

+0x3b fp=0x19e2504
makemap_c(0x55da40, 0x0, 0x0)
+0x76 fp=0x19e2528
runtime.makemap(0x55da40, 0x0, 0x0, 0x1e)
+0x3a fp=0x19e2538
+0x724 fp=0x19e2798
+0x10c fp=0x19e27cc
exit status 1
Build complete, duration 22m7.861s. Result: error: exit status 1


You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
postedJan 8, '14 at 9:51p
activeJan 8, '14 at 9:51p

1 user in discussion

Builder: 1 post



site design / logo © 2021 Grokbase