FAQ
Change e4cdf4d18e1e broke the openbsd-amd64-rootbsd build:
http://build.golang.org/log/68291059e36f8cadfb5bd6a85f2bf237107c6e99

runtime, gc: call interface conversion routines by reference.

Part of getting rid of vararg C calls.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/23310043

http://code.google.com/p/go/source/detail?r=e4cdf4d18e1e

$ tail -200 < log
ok crypto/cipher 0.013s
ok crypto/des 0.012s
ok crypto/dsa 0.040s
ok crypto/ecdsa 0.026s
ok crypto/elliptic 0.322s
ok crypto/hmac 0.044s
ok crypto/md5 0.006s
ok crypto/rand 0.022s
ok crypto/rc4 0.069s
ok crypto/rsa 1.002s
ok crypto/sha1 0.114s
ok crypto/sha256 0.005s
ok crypto/sha512 0.006s
ok crypto/subtle 0.077s
ok crypto/tls 2.821s
ok crypto/x509 1.859s
? crypto/x509/pkix [no test files]
ok database/sql 0.393s
ok database/sql/driver 0.005s
ok debug/dwarf 0.080s
ok debug/elf 0.089s
? debug/goobj [no test files]
ok debug/gosym 0.806s
ok debug/macho 0.662s
ok debug/pe 0.009s
? encoding [no test files]
ok encoding/ascii85 0.112s
ok encoding/asn1 0.007s
ok encoding/base32 0.086s
ok encoding/base64 0.006s
ok encoding/binary 0.069s
ok encoding/csv 0.006s
ok encoding/gob 0.080s
ok encoding/hex 0.082s
ok encoding/json 0.724s
ok encoding/pem 0.245s
ok encoding/xml 0.214s
ok errors 0.005s
ok expvar 0.177s
ok flag 0.006s
ok fmt 0.580s
ok go/ast 1.245s
ok go/build 1.441s
ok go/doc 0.459s
ok go/format 0.249s
ok go/parser 0.081s
ok go/printer 0.752s
ok go/scanner 0.597s
ok go/token 0.037s
? hash [no test files]
ok hash/adler32 0.012s
ok hash/crc32 0.004s
ok hash/crc64 0.040s
ok hash/fnv 0.005s
ok html 0.006s
ok html/template 0.445s
ok image 0.696s
ok image/color 0.129s
? image/color/palette [no test files]
ok image/draw 0.067s
ok image/gif 0.204s
ok image/jpeg 0.481s
ok image/png 0.259s
ok index/suffixarray 0.112s
ok io 0.601s
ok io/ioutil 0.498s
ok log 0.050s
ok log/syslog 2.641s
ok math 0.723s
ok math/big 0.922s
ok math/cmplx 0.111s
ok math/rand 0.020s
ok mime 0.005s
ok mime/multipart 1.445s
ok net 8.633s
ok net/http 7.373s
ok net/http/cgi 3.264s
ok net/http/cookiejar 0.552s
ok net/http/fcgi 0.087s
ok net/http/httptest 0.150s
ok net/http/httputil 0.447s
? net/http/pprof [no test files]
ok net/mail 0.060s
ok net/rpc 0.019s
ok net/rpc/jsonrpc 0.078s
ok net/smtp 0.009s
ok net/textproto 0.240s
ok net/url 0.006s
ok os 1.567s
ok os/exec 1.838s
ok os/signal 1.414s
ok os/user 0.398s
ok path 0.006s
ok path/filepath 0.568s
ok reflect 1.081s
ok regexp 0.880s
ok regexp/syntax 1.287s
ok runtime 41.692s
? runtime/cgo [no test files]
ok runtime/debug 1.269s
ok runtime/pprof 11.181s
? runtime/race [no test files]
ok sort 2.104s
ok strconv 1.844s
ok strings 3.202s
ok sync 2.906s
ok sync/atomic 2.945s
ok syscall 0.568s
ok testing 0.483s
? testing/iotest [no test files]
ok testing/quick 0.029s
ok text/scanner 0.007s
ok text/tabwriter 0.006s
ok text/template 0.482s
ok text/template/parse 0.423s
ok time 3.381s
ok unicode 0.365s
ok unicode/utf16 0.004s
ok unicode/utf8 0.008s
? unsafe [no test files]

real 6m10.844s
user 1m49.300s
sys 2m32.590s

# GOMAXPROCS=2 runtime -cpu=1,2,4
ok runtime 115.559s

# sync -cpu=10
ok sync 0.800s

# ../misc/cgo/stdio

# ../misc/cgo/life

# ../misc/cgo/test
PASS
ok
_/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
1.880s
PASS
ok
_/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
1.760s
PASS
ok
_/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
2.641s

# ../misc/cgo/testcdefs

# ../misc/cgo/testso

# ../misc/cgo/errors

# ../doc/progs

real 0m16.829s
user 0m9.130s
sys 0m4.180s

# ../doc/articles/wiki
rm -f get.bin final-test.bin a.out
PASS

# ../doc/codewalk

real 0m12.947s
user 0m1.820s
sys 0m1.240s

# ../misc/goplay

# ../test/bench/shootout
fasta
reverse-complement
nbody
binary-tree
binary-tree-freelist
fannkuch
fannkuch-parallel
regex-dna
regex-dna-parallel
spectral-norm
k-nucleotide
k-nucleotide-parallel
mandelbrot
meteor-contest
pidigits
threadring
chameneosredux

# ../test
# go run run.go -- chan/select5.go
incorrect output
# command-line-arguments
/tmp/796453206/tmp__.go:19326: out of memory

FAIL chan/select5.go 73.522s
exit status 1

real 5m58.328s
user 2m45.090s
sys 1m46.520s
Build complete, duration 18m21.41714005s. Result: error: exit status 1

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Joel Sing at Dec 18, 2013 at 12:49 pm

    On 18 December 2013 12:36, wrote:

    Change e4cdf4d18e1e broke the openbsd-amd64-rootbsd build:
    http://build.golang.org/log/68291059e36f8cadfb5bd6a85f2bf237107c6e99

    runtime, gc: call interface conversion routines by reference.

    Part of getting rid of vararg C calls.

    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/23310043

    http://code.google.com/p/go/source/detail?r=e4cdf4d18e1e

    $ tail -200 < log
    ok crypto/cipher 0.013s
    ok crypto/des 0.012s
    ok crypto/dsa 0.040s
    ok crypto/ecdsa 0.026s
    ok crypto/elliptic 0.322s
    ok crypto/hmac 0.044s
    ok crypto/md5 0.006s
    ok crypto/rand 0.022s
    ok crypto/rc4 0.069s
    ok crypto/rsa 1.002s
    ok crypto/sha1 0.114s
    ok crypto/sha256 0.005s
    ok crypto/sha512 0.006s
    ok crypto/subtle 0.077s
    ok crypto/tls 2.821s
    ok crypto/x509 1.859s
    ? crypto/x509/pkix [no test files]
    ok database/sql 0.393s
    ok database/sql/driver 0.005s
    ok debug/dwarf 0.080s
    ok debug/elf 0.089s
    ? debug/goobj [no test files]
    ok debug/gosym 0.806s
    ok debug/macho 0.662s
    ok debug/pe 0.009s
    ? encoding [no test files]
    ok encoding/ascii85 0.112s
    ok encoding/asn1 0.007s
    ok encoding/base32 0.086s
    ok encoding/base64 0.006s
    ok encoding/binary 0.069s
    ok encoding/csv 0.006s
    ok encoding/gob 0.080s
    ok encoding/hex 0.082s
    ok encoding/json 0.724s
    ok encoding/pem 0.245s
    ok encoding/xml 0.214s
    ok errors 0.005s
    ok expvar 0.177s
    ok flag 0.006s
    ok fmt 0.580s
    ok go/ast 1.245s
    ok go/build 1.441s
    ok go/doc 0.459s
    ok go/format 0.249s
    ok go/parser 0.081s
    ok go/printer 0.752s
    ok go/scanner 0.597s
    ok go/token 0.037s
    ? hash [no test files]
    ok hash/adler32 0.012s
    ok hash/crc32 0.004s
    ok hash/crc64 0.040s
    ok hash/fnv 0.005s
    ok html 0.006s
    ok html/template 0.445s
    ok image 0.696s
    ok image/color 0.129s
    ? image/color/palette [no test files]
    ok image/draw 0.067s
    ok image/gif 0.204s
    ok image/jpeg 0.481s
    ok image/png 0.259s
    ok index/suffixarray 0.112s
    ok io 0.601s
    ok io/ioutil 0.498s
    ok log 0.050s
    ok log/syslog 2.641s
    ok math 0.723s
    ok math/big 0.922s
    ok math/cmplx 0.111s
    ok math/rand 0.020s
    ok mime 0.005s
    ok mime/multipart 1.445s
    ok net 8.633s
    ok net/http 7.373s
    ok net/http/cgi 3.264s
    ok net/http/cookiejar 0.552s
    ok net/http/fcgi 0.087s
    ok net/http/httptest 0.150s
    ok net/http/httputil 0.447s
    ? net/http/pprof [no test files]
    ok net/mail 0.060s
    ok net/rpc 0.019s
    ok net/rpc/jsonrpc 0.078s
    ok net/smtp 0.009s
    ok net/textproto 0.240s
    ok net/url 0.006s
    ok os 1.567s
    ok os/exec 1.838s
    ok os/signal 1.414s
    ok os/user 0.398s
    ok path 0.006s
    ok path/filepath 0.568s
    ok reflect 1.081s
    ok regexp 0.880s
    ok regexp/syntax 1.287s
    ok runtime 41.692s
    ? runtime/cgo [no test files]
    ok runtime/debug 1.269s
    ok runtime/pprof 11.181s
    ? runtime/race [no test files]
    ok sort 2.104s
    ok strconv 1.844s
    ok strings 3.202s
    ok sync 2.906s
    ok sync/atomic 2.945s
    ok syscall 0.568s
    ok testing 0.483s
    ? testing/iotest [no test files]
    ok testing/quick 0.029s
    ok text/scanner 0.007s
    ok text/tabwriter 0.006s
    ok text/template 0.482s
    ok text/template/parse 0.423s
    ok time 3.381s
    ok unicode 0.365s
    ok unicode/utf16 0.004s
    ok unicode/utf8 0.008s
    ? unsafe [no test files]

    real 6m10.844s
    user 1m49.300s
    sys 2m32.590s

    # GOMAXPROCS=2 runtime -cpu=1,2,4
    ok runtime 115.559s

    # sync -cpu=10
    ok sync 0.800s

    # ../misc/cgo/stdio

    # ../misc/cgo/life

    # ../misc/cgo/test
    PASS
    ok _/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
    1.880s
    PASS
    ok _/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
    1.760s
    PASS
    ok _/home/gopher/gobuilder/openbsd-amd64-rootbsd-e4cdf4d18e1e/go/misc/cgo/test
    2.641s

    # ../misc/cgo/testcdefs

    # ../misc/cgo/testso

    # ../misc/cgo/errors

    # ../doc/progs

    real 0m16.829s
    user 0m9.130s
    sys 0m4.180s

    # ../doc/articles/wiki
    rm -f get.bin final-test.bin a.out
    PASS

    # ../doc/codewalk

    real 0m12.947s
    user 0m1.820s
    sys 0m1.240s

    # ../misc/goplay

    # ../test/bench/shootout
    fasta
    reverse-complement
    nbody
    binary-tree
    binary-tree-freelist
    fannkuch
    fannkuch-parallel
    regex-dna
    regex-dna-parallel
    spectral-norm
    k-nucleotide
    k-nucleotide-parallel
    mandelbrot
    meteor-contest
    pidigits
    threadring
    chameneosredux

    # ../test
    # go run run.go -- chan/select5.go
    incorrect output
    # command-line-arguments
    /tmp/796453206/tmp__.go:19326: out of memory

    FAIL chan/select5.go 73.522s
    exit status 1

    real 5m58.328s
    user 2m45.090s
    sys 1m46.520s
    Build complete, duration 18m21.41714005s. Result: error: exit status 1

    This change seems to have pushed up the memory requirements for
    test/chan/select5.go considerably - we're hitting the ulimit, which is
    resulting the test being terminated:

    With a0c8cab3e171:

    [gopher@w564 ~/src/go/test 34]$ /usr/bin/time -l go run run.go --
    chan/select5.go
            50.36 real 48.77 user 0.81 sys
         391900 maximum resident set size
              0 average shared memory size
              0 average unshared data size
              0 average unshared stack size
         152554 minor page faults
            913 major page faults
              0 swaps
              0 block input operations
           1833 block output operations
              0 messages sent
              0 messages received
             14 signals received
           7333 voluntary context switches
           1456 involuntary context switches

    With tip (12a40bc39413):

    [gopher@w564 ~/src/go/test 41]$ /usr/bin/time -l go run run.go --
    chan/select5.go
           169.47 real 59.86 user 46.21 sys
         752084 maximum resident set size
              0 average shared memory size
              0 average unshared data size
              0 average unshared stack size
         330239 minor page faults
         182224 major page faults
              0 swaps
             44 block input operations
           2763 block output operations
              0 messages sent
              0 messages received
             11 signals received
         208392 voluntary context switches
           3200 involuntary context switches

    Is this expected?

    For now I've bumped the limits...

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 18, '13 at 1:36a
activeDec 18, '13 at 12:49p
posts2
users2
websitegolang.org

2 users in discussion

Builder: 1 post Joel Sing: 1 post

People

Translate

site design / logo © 2021 Grokbase