FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
ld: fix Plan 9 build

Please review this at https://codereview.appspot.com/43420043/

Affected files (+1, -1 lines):
    M src/cmd/ld/pobj.c


Index: src/cmd/ld/pobj.c
===================================================================
--- a/src/cmd/ld/pobj.c
+++ b/src/cmd/ld/pobj.c
@@ -138,7 +138,7 @@
    if(HEADTYPE == -1)
     HEADTYPE = headtype(goos);
    ctxt->headtype = HEADTYPE;
- if (headstring == NULL)
+ if (headstring == nil)
     headstring = headstr(HEADTYPE);

    archinit();


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Jas at Dec 17, 2013 at 3:48 pm
    lgtm

    you also used a more apt title than I just tried, build: NULL is nil

    https://codereview.appspot.com/43420043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Dec 17, 2013 at 4:46 pm
    LGTM


    On Tue, Dec 17, 2013 at 5:27 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    ld: fix Plan 9 build

    Please review this at https://codereview.appspot.com/43420043/

    Affected files (+1, -1 lines):
    M src/cmd/ld/pobj.c


    Index: src/cmd/ld/pobj.c
    ===================================================================
    --- a/src/cmd/ld/pobj.c
    +++ b/src/cmd/ld/pobj.c
    @@ -138,7 +138,7 @@
    if(HEADTYPE == -1)
    HEADTYPE = headtype(goos);
    ctxt->headtype = HEADTYPE;
    - if (headstring == NULL)
    + if (headstring == nil)
    headstring = headstr(HEADTYPE);

    archinit();


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Bradfitz at Dec 17, 2013 at 4:46 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=8cb5c6892fbc ***

    ld: fix Plan 9 build

    R=golang-dev, jas, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/43420043

    Committer: Brad Fitzpatrick <bradfitz@golang.org>


    https://codereview.appspot.com/43420043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 17, '13 at 1:27p
activeDec 17, '13 at 4:46p
posts4
users3
websitegolang.org

3 users in discussion

Bradfitz: 2 posts 0intro: 1 post Jas: 1 post

People

Translate

site design / logo © 2021 Grokbase