FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
go/build: fix deps_test on Plan 9

On Plan 9, net depends on strings.

Please review this at https://codereview.appspot.com/41480044/

Affected files (+1, -1 lines):
    M src/pkg/go/build/deps_test.go


Index: src/pkg/go/build/deps_test.go
===================================================================
--- a/src/pkg/go/build/deps_test.go
+++ b/src/pkg/go/build/deps_test.go
@@ -239,7 +239,7 @@
    // Basic networking.
    // Because net must be used by any package that wants to
    // do networking portably, it must have a small dependency set: just
L1+basic os.
- "net": {"L1", "CGO", "os", "syscall", "time"},
+ "net": {"L1", "CGO", "os", "syscall", "time", "strings"},

    // NET enables use of basic network-related packages.
    "NET": {


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Brad Fitzpatrick at Dec 17, 2013 at 9:04 pm
    I don't think that's acceptable.

    Right now, a program using only net doesn't bring in unicode and all their
    tables. This would change that.

    Perhaps you should just remove the strings dependency and make your own
    (ASCII-only) toLower function in pkg net. I didn't catch that before. I
    guess I assumed all.bash passed before you sent the patch, but I guess
    plan9 is only just getting there now.


    On Tue, Dec 17, 2013 at 12:50 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    go/build: fix deps_test on Plan 9

    On Plan 9, net depends on strings.

    Please review this at https://codereview.appspot.com/41480044/

    Affected files (+1, -1 lines):
    M src/pkg/go/build/deps_test.go


    Index: src/pkg/go/build/deps_test.go
    ===================================================================
    --- a/src/pkg/go/build/deps_test.go
    +++ b/src/pkg/go/build/deps_test.go
    @@ -239,7 +239,7 @@
    // Basic networking.
    // Because net must be used by any package that wants to
    // do networking portably, it must have a small dependency set:
    just L1+basic os.
    - "net": {"L1", "CGO", "os", "syscall", "time"},
    + "net": {"L1", "CGO", "os", "syscall", "time", "strings"},

    // NET enables use of basic network-related packages.
    "NET": {


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • 0intro at Dec 17, 2013 at 9:10 pm

    Perhaps you should just remove the strings dependency and make your own
    (ASCII-only) toLower function in pkg net.
    Sorry, I haven't seen the failing test before. I'll do that.

    https://codereview.appspot.com/41480044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • 0intro at Dec 17, 2013 at 9:10 pm
    *** Abandoned ***

    https://codereview.appspot.com/41480044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 17, '13 at 8:50p
activeDec 17, '13 at 9:10p
posts4
users2
websitegolang.org

2 users in discussion

0intro: 3 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2021 Grokbase