FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
liblink: fix Plan 9 build

Please review this at https://codereview.appspot.com/39280043/

Affected files (+11, -2 lines):
    M include/plan9/386/u.h
    M include/plan9/amd64/u.h
    A include/plan9/link.h
    M src/liblink/data.c


Index: include/plan9/386/u.h
===================================================================
--- a/include/plan9/386/u.h
+++ b/include/plan9/386/u.h
@@ -13,3 +13,5 @@
   typedef vlong int64;
   typedef uvlong uint64;
   typedef int intptr;
+typedef float float32;
+typedef double float64;
Index: include/plan9/amd64/u.h
===================================================================
--- a/include/plan9/amd64/u.h
+++ b/include/plan9/amd64/u.h
@@ -13,3 +13,5 @@
   typedef vlong int64;
   typedef uvlong uint64;
   typedef vlong intptr;
+typedef float float32;
+typedef double float64;
Index: include/plan9/link.h
===================================================================
new file mode 100644
--- /dev/null
+++ b/include/plan9/link.h
@@ -0,0 +1,5 @@
+// Copyright 2013 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+#include "../link.h"
Index: src/liblink/data.c
===================================================================
--- a/src/liblink/data.c
+++ b/src/liblink/data.c
@@ -99,7 +99,7 @@
      s->p[off+i] = p->to.u.sval[i];
    } else if(p->to.type == ctxt->arch->D_CONST) {
     if(p->to.sym)
- goto Addr;
+ goto addr;
     o = p->to.offset;
     fl = o;
     cast = (uchar*)&fl;
@@ -125,7 +125,7 @@
      break;
     }
    } else if(p->to.type == ctxt->arch->D_ADDR || p->to.type ==
ctxt->arch->D_SIZE) {
- Addr:
+ addr:
     r = addrel(s);
     r->off = off;
     r->siz = siz;


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Dec 9, 2013 at 12:54 pm
    LGTM

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Rsc at Dec 9, 2013 at 12:56 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=821bb484720f ***

    liblink: fix Plan 9 build

    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/39280043

    Committer: Russ Cox <rsc@golang.org>


    https://codereview.appspot.com/39280043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 9, '13 at 6:37a
activeDec 9, '13 at 12:56p
posts3
users2
websitegolang.org

2 users in discussion

Rsc: 2 posts 0intro: 1 post

People

Translate

site design / logo © 2021 Grokbase