FAQ
https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go
File ssh/client_auth.go (right):

https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159
ssh/client_auth.go:159: Signers() ([]Signer, error)
On 2013/12/02 18:38:04, agl1 wrote:
As ever with a one-element interface, it's worth considering whether it should
just be a callback.
Although, given the possiblity of needing to add more functions to the interface
in the future, maybe it's not right here.
if you're OK with this CL, I will change to callbacks in a follow-up CL.

https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode187
ssh/client_auth.go:187: ids, err := p.Signers()
On 2013/12/02 18:38:04, agl1 wrote:
(nit: ignore if don't like it). I would probably s/ids/signers/ and
change the
iteration variable in line 192 and 204 to |signer|
Done.

https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode219
ssh/client_auth.go:219: s := serializeSignature(pub.PublicKeyAlgo(),
sign)
On 2013/12/02 18:30:32, jpsugar wrote:
algoname?
Done.

https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode356
ssh/client_auth.go:356: return s.agent.SignRequest(s.pub, data)
On 2013/12/02 18:38:04, agl1 wrote:
I guess the agent is expected to have its own entropy source.
Done.

https://codereview.appspot.com/35110043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Agl at Dec 3, 2013 at 3:29 pm
    LGTM


    https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go
    File ssh/client_auth.go (right):

    https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159
    ssh/client_auth.go:159: Signers() ([]Signer, error)
    On 2013/12/03 09:59:11, hanwen-google wrote:
    if you're OK with this CL, I will change to callbacks in a follow-up
    CL.

    p.s. totally fine if you *don't* change to callbacks too. It's just a
    point to consider. I don't think there's a clearly correct answer in
    this case.

    https://codereview.appspot.com/35110043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Hanwen at Dec 3, 2013 at 3:36 pm
    https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go
    File ssh/client_auth.go (right):

    https://codereview.appspot.com/35110043/diff/40001/ssh/client_auth.go#newcode159
    ssh/client_auth.go:159: Signers() ([]Signer, error)
    On 2013/12/03 15:29:26, agl1 wrote:
    On 2013/12/03 09:59:11, hanwen-google wrote:
    if you're OK with this CL, I will change to callbacks in a follow-up
    CL.
    p.s. totally fine if you *don't* change to callbacks too. It's just a point to
    consider. I don't think there's a clearly correct answer in this case.
    Can you think of other methods you'd want to add to these interfaces?

    We can punt on resolving this for now, but I think we should decide on
    interface vs callback before we unleash the rewritten API onto the
    public.

    https://codereview.appspot.com/35110043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Hanwen at Dec 3, 2013 at 3:44 pm
    *** Submitted as
    https://code.google.com/p/gosshnew/source/detail?r=4b6c2dde8ede ***

    gosshnew/ssh: pubkey client-side auth now returns []Signer.

    R=agl, dave, jpsugar
    CC=agl, dave, golang-dev, hanwen, jpsugar
    https://codereview.appspot.com/35110043


    https://codereview.appspot.com/35110043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedDec 3, '13 at 9:59a
activeDec 3, '13 at 3:44p
posts4
users2
websitegolang.org

2 users in discussion

Hanwen: 3 posts Agl: 1 post

People

Translate

site design / logo © 2021 Grokbase