FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/ssa/interp: fix Plan 9 build for Brad

Please review this at https://codereview.appspot.com/26500043/

Affected files (+11, -7 lines):
    M ssa/interp/external.go
    M ssa/interp/external_plan9.go
    M ssa/interp/external_unix.go
    M ssa/interp/external_windows.go


Index: ssa/interp/external.go
===================================================================
--- a/ssa/interp/external.go
+++ b/ssa/interp/external.go
@@ -328,10 +328,6 @@
    return syscall.Getpid()
   }

-func ext۰syscall۰RawSyscall(fn *ssa.Function, args []value) value {
- return tuple{uintptr(0), uintptr(0), uintptr(syscall.ENOSYS)}
-}
-
   func valueToBytes(v value) []byte {
    in := v.([]value)
    b := make([]byte, len(in))
Index: ssa/interp/external_plan9.go
===================================================================
--- a/ssa/interp/external_plan9.go
+++ b/ssa/interp/external_plan9.go
@@ -5,8 +5,6 @@
   package interp

   import (
- "syscall"
-
    "code.google.com/p/go.tools/ssa"
   )

@@ -42,3 +40,6 @@
    n, err := write(args[0].(int), valueToBytes(args[1]))
    return tuple{n, wrapError(err)}
   }
+func ext۰syscall۰RawSyscall(fn *ssa.Function, args []value) value {
+ return tuple{^uintptr(0), uintptr(0), uintptr(0)}
+}
Index: ssa/interp/external_unix.go
===================================================================
--- a/ssa/interp/external_unix.go
+++ b/ssa/interp/external_unix.go
@@ -126,3 +126,7 @@
    n, err := write(args[0].(int), valueToBytes(args[1]))
    return tuple{n, wrapError(err)}
   }
+
+func ext۰syscall۰RawSyscall(fn *ssa.Function, args []value) value {
+ return tuple{uintptr(0), uintptr(0), uintptr(syscall.ENOSYS)}
+}
Index: ssa/interp/external_windows.go
===================================================================
--- a/ssa/interp/external_windows.go
+++ b/ssa/interp/external_windows.go
@@ -2,7 +2,7 @@
   // Use of this source code is governed by a BSD-style
   // license that can be found in the LICENSE file.

-// +build windows plan9
+// +build windows

   package interp

@@ -40,3 +40,6 @@
   func ext۰syscall۰Write(fn *ssa.Function, args []value) value {
    panic("syscall.Write not yet implemented")
   }
+func ext۰syscall۰RawSyscall(fn *ssa.Function, args []value) value {
+ return tuple{uintptr(0), uintptr(0), uintptr(syscall.ENOSYS)}
+}


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Rsc at Nov 14, 2013 at 3:20 pm
    LGTM



    https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go
    File ssa/interp/external_windows.go (right):

    https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go#newcode5
    ssa/interp/external_windows.go:5: // +build windows
    this line does nothing: the file is named external_windows.go, so there
    is already an implicit "only windows" build constraint. (for the same
    reason, the line allowing "windows OR plan9" was also having no effect:
    windows AND (windows OR plan9) is just windows.)

    https://codereview.appspot.com/26500043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedNov 14, '13 at 9:57a
activeNov 14, '13 at 3:20p
posts2
users2
websitegolang.org

2 users in discussion

Rsc: 1 post Ality: 1 post

People

Translate

site design / logo © 2021 Grokbase