FAQ
Reviewers: bradfitz,

Message:
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/leveldb-go


Description:
leveldb: create the DB if it doesn't already exist.

Add a FileSystem.Stat method and change memfs' errors to satisfy
os.IsNotExist when appropriate.

Add a ErrorIfDBExists option. The C++ code also has a CreateIfMissing
option, but I feel like you'd always want to set it to true (IIUC the
C++ code still writes and possibly deletes files even if you open a
DB 'just for reading'), and so I've left it out of the Go options.

Please review this at https://codereview.appspot.com/17550044/

Affected files (+121, -21 lines):
    M leveldb/compaction_test.go
    M leveldb/db/file.go
    M leveldb/db/options.go
    M leveldb/leveldb.go
    M leveldb/leveldb_test.go
    M leveldb/memfs/memfs.go
    M leveldb/version_set.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Bradfitz at Oct 29, 2013 at 11:34 pm
    LGTM


    https://codereview.appspot.com/17550044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Nigeltao at Oct 30, 2013 at 1:54 am
    *** Submitted as
    https://code.google.com/p/leveldb-go/source/detail?r=01e062dd7adc ***

    leveldb: create the DB if it doesn't already exist.

    Add a FileSystem.Stat method and change memfs' errors to satisfy
    os.IsNotExist when appropriate.

    Add a ErrorIfDBExists option. The C++ code also has a CreateIfMissing
    option, but I feel like you'd always want to set it to true (IIUC the
    C++ code still writes and possibly deletes files even if you open a
    DB 'just for reading'), and so I've left it out of the Go options.

    R=bradfitz
    CC=golang-dev
    https://codereview.appspot.com/17550044


    https://codereview.appspot.com/17550044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 29, '13 at 7:03a
activeOct 30, '13 at 1:54a
posts3
users2
websitegolang.org

2 users in discussion

Nigeltao: 2 posts Bradfitz: 1 post

People

Translate

site design / logo © 2021 Grokbase