FAQ
LGTM. (For landing in gosshnew.)


https://codereview.appspot.com/14494058/diff/460001/ssh/common.go
File ssh/common.go (right):

https://codereview.appspot.com/14494058/diff/460001/ssh/common.go#newcode153
ssh/common.go:153: // The maximum amount of data sent or received after
which a
s/amount of data/number of bytes/

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go
File ssh/handshake.go (right):

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go#newcode30
ssh/handshake.go:30: // Returns the session ID. prepareKeyChange must
have been
getSessionID returns the session ID. ...

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go#newcode40
ssh/handshake.go:40: // requestKeyChange asks remote side to change
keys. All
"asks the"

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go#newcode45
ssh/handshake.go:45: // Returns the session ID. This is only valid after
the first
getSessionID returns the session ID ...

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go#newcode175
ssh/handshake.go:175: if p[0] == msgKexInit {
(nit): by testing p[0] != msgKeyInit and returning immediately, the code
to handle the msgKexInit could have one less level of indentation.

https://codereview.appspot.com/14494058/diff/460001/ssh/handshake.go#newcode223
ssh/handshake.go:223: // internalSendKexInit sends key change message.
t.mu must be locked
"sends a"

https://codereview.appspot.com/14494058/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 29, '13 at 2:33p
activeOct 31, '13 at 2:36p
posts5
users2
websitegolang.org

2 users in discussion

Hanwen: 3 posts Agl: 2 posts

People

Translate

site design / logo © 2021 Grokbase