|| at Oct 17, 2013 at 5:56 pm
Can we just eat the newKeys message instead of passing it up and having
it be ignored?https://codereview.appspot.com/14494058/diff/45001/ssh/client.go
File ssh/client.go (right):https://codereview.appspot.com/14494058/diff/45001/ssh/client.go#newcode84
ssh/client.go:84: // discard newkeys packet.
Do we want to ensure that it's a newkeys packet?https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go
File ssh/handshake.go (right):https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode16
ssh/handshake.go:16: //const debug = true
Replace this with an explanation of what this does?https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode47
ssh/handshake.go:47: hostKeys Signer // If hostKeys are given, we are
Missing period on comment.
I think this is a really important thing to note in the protocol.
Accidentally missing hostKeys causes us to completely flip our role in
the exchange, which would probably produce weird errors. It may be
simpler and safer to have a bool isServer or similar.https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode80
ssh/handshake.go:80: func newClientTransport(conn keyingTransport,
clientVersion, serverVersion byte,
Wrap at 80, 120, or don't wrap. Wrapping at 82 is weird. :-) I prefer no
ssh/handshake.go:91: func newServerTransport(
Why are the args on a new line?https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode154
ssh/handshake.go:154: // This is not completely accurate, as the debug
Add a TODO?https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode228
ssh/handshake.go:228: scramble := make(byte, len(packet))
I'm not a fan of "scramble". "packetCopy"?https://codereview.appspot.com/14494058/diff/45001/ssh/handshake.go#newcode256
ssh/handshake.go:278: clientInit := otherInit
If I'm reading this correctly, these four vars only really affect the
magics. Can we fold this directly into the init of the magics?https://codereview.appspot.com/14494058/diff/45001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):https://codereview.appspot.com/14494058/diff/45001/ssh/test/test_unix_test.go#newcode110
ssh/test/test_unix_test.go:110: checkCount int
What is this checkCount for?https://codereview.appspot.com/14494058/
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to email@example.com.
For more options, visit https://groups.google.com/groups/opt_out.