FAQ
Good news everyone! The test has been running for 12 hours and
db.numOpen matches the number of connections open in the server, so I
guess we have a fix for this problem. This morning I also came up with a
test for it and, in the process, found another couple of bugs in sql.go
and another one in sql_test.go.

Please, let me know when you're back to work so I can submit the CLs and
get them merged quickly and then we can decide on a final solution for
this issue. The current one is probably the optimal when it comes to
performance but it makes some tests fail. We would need either to adjust
the tests or discard the connection when the idle queue is full while
also closing it.

Regards,
Alberto

https://codereview.appspot.com/14611045/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/047d7bacc4d4918bc404e89d42f9%40google.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Brad Fitzpatrick at Oct 13, 2013 at 5:55 pm
    Please mail your CLs when they're ready. I'll look Tuesday morning
    US/Pacific.
      On Oct 13, 2013 1:00 AM, wrote:

    Good news everyone! The test has been running for 12 hours and
    db.numOpen matches the number of connections open in the server, so I
    guess we have a fix for this problem. This morning I also came up with a
    test for it and, in the process, found another couple of bugs in sql.go
    and another one in sql_test.go.

    Please, let me know when you're back to work so I can submit the CLs and
    get them merged quickly and then we can decide on a final solution for
    this issue. The current one is probably the optimal when it comes to
    performance but it makes some tests fail. We would need either to adjust
    the tests or discard the connection when the idle queue is full while
    also closing it.

    Regards,
    Alberto

    https://codereview.appspot.**com/14611045/<https://codereview.appspot.com/14611045/>
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/CAFzRk01zapeRXfAM0n9LitFFmmtqRAfLdPZhsXmyKuiK_VsehA%40mail.gmail.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 13, '13 at 11:00a
activeOct 13, '13 at 5:55p
posts2
users2
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase