FAQ
It seems that there are still some connection leaks even after applying
this patch, although they happen way more slowly than before. I'm
currently investigating the issue. Please, don't merge it in the
meantime.

https://codereview.appspot.com/14611045/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Alberto Garcia Hierro at Oct 12, 2013 at 10:57 am

    On 2013/10/12 09:55:58, Hierro wrote:
    It seems that there are still some connection leaks even after
    applying this
    patch, although they happen way more slowly than before. I'm currently
    investigating the issue. Please, don't merge it in the meantime.
    After further investigation I've found and fixed a connection leak in
    our ORM, so the CL still seems to be correct. I will let our development
    server run for a few hours while load testing it with ab and then I'll
    report the results later.

    Regards,
    Alberto

    https://codereview.appspot.com/14611045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Oct 12, 2013 at 9:00 pm
    Please report back. Time is running short on Go 1.2, but this is why we
    have rc releases, to encourage people to use it and find bugs.

    I'm back to work in a few days and will try to write a test for this,
    unless you beat me to it. I think it's probably possible to instrument the
    fake driver to control its open-new-connection timing for this particular
    test.



    On Sat, Oct 12, 2013 at 12:57 AM, wrote:
    On 2013/10/12 09:55:58, Hierro wrote:

    It seems that there are still some connection leaks even after
    applying this
    patch, although they happen way more slowly than before. I'm currently
    investigating the issue. Please, don't merge it in the meantime.
    After further investigation I've found and fixed a connection leak in
    our ORM, so the CL still seems to be correct. I will let our development
    server run for a few hours while load testing it with ab and then I'll
    report the results later.

    Regards,
    Alberto

    https://codereview.appspot.**com/14611045/<https://codereview.appspot.com/14611045/>
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/CAFzRk02nUxcqNcspAyvX90seSxkhpPKxmzNKM21dFue_DBJ4KQ%40mail.gmail.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Alberto Garcia Hierro at Oct 12, 2013 at 10:13 pm

    On 2013/10/12 21:00:54, bradfitz wrote:
    Please report back. Time is running short on Go 1.2, but this is why we
    have rc releases, to encourage people to use it and find bugs.
    I'm back to work in a few days and will try to write a test for this,
    unless you beat me to it. I think it's probably possible to
    instrument the
    fake driver to control its open-new-connection timing for this
    particular
    test.
    I just came back home and, unfortunately, it seems I didn't properly
    start the test before leaving (I was already late and setting up the
    test in a rush). I'll leave it running over the night and I'll report
    back tomorrow.

    On the other hand, I just took a quick look a the fake driver and it
    seems I could easily make a test for this. It looks like the only
    significant thing I'd need to add to the the fake driver would be a
    configurable delay when opening a new connection. Would that be OK?

    Regards,
    Alberto

    https://codereview.appspot.com/14611045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/089e013a17142788c104e8928a4f%40google.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Oct 12, 2013 at 10:36 pm
    Don't use time.Sleep in the fake driver. Control operation order with
    channels.
      On Oct 12, 2013 12:13 PM, wrote:
    On 2013/10/12 21:00:54, bradfitz wrote:

    Please report back. Time is running short on Go 1.2, but this is why we
    have rc releases, to encourage people to use it and find bugs.
    I'm back to work in a few days and will try to write a test for this,
    unless you beat me to it. I think it's probably possible to
    instrument the
    fake driver to control its open-new-connection timing for this
    particular
    test.
    I just came back home and, unfortunately, it seems I didn't properly
    start the test before leaving (I was already late and setting up the
    test in a rush). I'll leave it running over the night and I'll report
    back tomorrow.

    On the other hand, I just took a quick look a the fake driver and it
    seems I could easily make a test for this. It looks like the only
    significant thing I'd need to add to the the fake driver would be a
    configurable delay when opening a new connection. Would that be OK?

    Regards,
    Alberto

    https://codereview.appspot.**com/14611045/<https://codereview.appspot.com/14611045/>
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    To view this discussion on the web visit https://groups.google.com/d/msgid/golang-dev/CAFzRk008SCCaxRP9yVnxboyyTY%3Dzb6Lo6kwzWQooO8h_D5rBFg%40mail.gmail.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedOct 12, '13 at 9:56a
activeOct 12, '13 at 10:36p
posts5
users2
websitegolang.org

People

Translate

site design / logo © 2021 Grokbase