FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.
Fixes issue 6431.

Change suggested by kin.wilson.za.

Please review this at https://codereview.appspot.com/13314048/

Affected files (+1, -0 lines):
    M src/cmd/ld/pe.c


Index: src/cmd/ld/pe.c
===================================================================
--- a/src/cmd/ld/pe.c
+++ b/src/cmd/ld/pe.c
@@ -151,6 +151,7 @@

    // some mingw libs depend on this symbol, for example, FindPESectionByName
    xdefine("__image_base__", SDATA, PEBASE);
+ xdefine("_image_base__", SDATA, PEBASE);
   }

   static void


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Sep 23, 2013 at 2:05 pm
    LGTM

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Minux Ma at Sep 23, 2013 at 7:02 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=46b68d2aa38e ***

    cmd/ld: fix "_image_base__ not defined" problem for cmd/8l.
    Fixes issue 6431.

    Change suggested by kin.wilson.za.

    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/13314048


    https://codereview.appspot.com/13314048/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 23, '13 at 4:14a
activeSep 23, '13 at 7:02p
posts3
users2
websitegolang.org

2 users in discussion

Minux Ma: 2 posts Russ Cox: 1 post

People

Translate

site design / logo © 2022 Grokbase