FAQ

On 2013/09/16 15:18:02, rsc wrote:
not lgtm
sorry, too many lines changing for the freeze. ...
That is fine, we'll wait till after 1.2.
... i am also a little skeptical
about this.
I think, regardless of speed improvements, we should make this change.
Why rand generator is buffered on unix and not buffered on windows?
... is the C function we're calling on windows really that terrible?
It also could be really fast, and we just see the cost of syscall ...
On 2013/09/16 16:29:30, mxk wrote:
Benchmarks are below. ...
If we are to proceed with this CL, please include your benchmarks.
... I don't know if it's the function itself or just the
syscall overhead. ...
You could write a benchmark calling simple Windows API that does not do
much (for example GetLastError), and compare it with calling
CryptAcquireContext.

Alex

https://codereview.appspot.com/13256052/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Maxim Khitrov at Sep 17, 2013 at 12:45 pm

    On Mon, Sep 16, 2013 at 10:03 PM, wrote:
    If we are to proceed with this CL, please include your benchmarks. Done.
    You could write a benchmark calling simple Windows API that does not do
    much (for example GetLastError), and compare it with calling
    CryptAcquireContext.
    CryptAcquireContext is only done once, I assume you meant
    CryptGenRandom. Replacing it with GetLastError results in 111 ns/op
    for BenchmarkReader1, while the original version is 1257 ns/op. So
    it's not the syscall overhead, CryptGenRandom is just slow.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 17, '13 at 2:03a
activeSep 17, '13 at 12:45p
posts2
users2
websitegolang.org

2 users in discussion

Maxim Khitrov: 1 post Alex Brainman: 1 post

People

Translate

site design / logo © 2022 Grokbase