FAQ
Reviewers: rsc,

Message:
Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
cmd/gc: fix set but not used error

Please review this at https://codereview.appspot.com/13749044/

Affected files (+0, -2 lines):
    M src/cmd/gc/popt.c


Index: src/cmd/gc/popt.c
===================================================================
--- a/src/cmd/gc/popt.c
+++ b/src/cmd/gc/popt.c
@@ -795,7 +795,6 @@
   {
    NilFlow *r;
    Prog *p;
- uint32 gen;
    Graph *g;
    int ncheck, nkill;

@@ -806,7 +805,6 @@
    if(debug_checknil > 1 /* || strcmp(curfn->nname->sym->name, "f1") == 0 */)
     dumpit("nilopt", g->start, 0);

- gen = 0;
    ncheck = 0;
    nkill = 0;
    for(r = (NilFlow*)g->start; r != nil; r = (NilFlow*)r->f.link) {


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R at Sep 17, 2013 at 11:41 pm
    LGTM


    https://codereview.appspot.com/13749044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave at Sep 18, 2013 at 12:16 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=d7a0e5c5e700 ***

    cmd/gc: fix set but not used error

    R=rsc, r
    CC=golang-dev
    https://codereview.appspot.com/13749044


    https://codereview.appspot.com/13749044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 17, '13 at 11:27p
activeSep 18, '13 at 12:16a
posts3
users2
websitegolang.org

2 users in discussion

Dave: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase