FAQ
LGTM after tweaks.



https://codereview.appspot.com/13647043/diff/15001/language/language.go
File language/language.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/language.go#newcode169
language/language.go:169: // Canonicalize replaces the tag with its
canonical equivalent.
it doesn't really replace it, it returns it. It's a value. how about

Canonicalize returns the canonicalized equivalent of the tag.

there's another occurrence above.

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go
File language/lookup.go (right):

https://codereview.appspot.com/13647043/diff/15001/language/lookup.go#newcode199
language/lookup.go:199: func (b langID) String() string {
b is an odd choice here. i would have thought 'id'.
several more methods below.

https://codereview.appspot.com/13647043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Mpvl at Sep 16, 2013 at 6:17 am
    https://codereview.appspot.com/13647043/diff/15001/language/language.go
    File language/language.go (right):

    https://codereview.appspot.com/13647043/diff/15001/language/language.go#newcode169
    language/language.go:169: // Canonicalize replaces the tag with its
    canonical equivalent.
    On 2013/09/16 03:06:37, r wrote:
    it doesn't really replace it, it returns it. It's a value. how about
    Canonicalize returns the canonicalized equivalent of the tag.
    there's another occurrence above.
    Done.

    https://codereview.appspot.com/13647043/diff/15001/language/lookup.go
    File language/lookup.go (right):

    https://codereview.appspot.com/13647043/diff/15001/language/lookup.go#newcode199
    language/lookup.go:199: func (b langID) String() string {
    langID is embedded in type Base. So the public methods from langID show
    up in the documentation with this variable name. I favored a consistent
    naming of the public type over an consistent naming of the private type.
       I could also rename all the other internal methods of langID to be
    consistent if you prefer.
    On 2013/09/16 03:06:37, r wrote:
    b is an odd choice here. i would have thought 'id'.
    several more methods below.
    https://codereview.appspot.com/13647043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Rob Pike at Sep 16, 2013 at 6:18 am
    i'll leave the renaming decision up to you. in the CL it just looked odd.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 16, '13 at 3:06a
activeSep 16, '13 at 6:18a
posts3
users2
websitegolang.org

2 users in discussion

Rob Pike: 2 posts Mpvl: 1 post

People

Translate

site design / logo © 2021 Grokbase