FAQ
PTAL

I named the opt-in knob "MultiAttempt" because we could use it not only
for multiple addresses on multiple address families but for multiple
addresses on a single address family near the future. But honestly, not
sure. Suggestions for a better name welcome.


https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/dial.go
File src/pkg/net/dial.go (right):

https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/dial.go#newcode169
src/pkg/net/dial.go:169: // the list of addresses. It will return a
fisrt established
On 2013/09/04 17:50:59, bradfitz wrote:
typo
also: the first, not a first
Done.

https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/dial.go#newcode179
src/pkg/net/dial.go:179: // by using multiple Dial racers, we use both
channels signal
On 2013/09/04 17:50:59, bradfitz wrote:
sig and lane
Done.

https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/dial.go#newcode183
src/pkg/net/dial.go:183: sig, lane := make(chan bool, 1), make(chan
racer, 1)
On 2013/09/04 17:50:59, bradfitz wrote:
break these up into separate lines and comment each separately. maybe that
would help.
Done.

https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/fd_unix.go
File src/pkg/net/fd_unix.go (right):

https://codereview.appspot.com/12416043/diff/163001/src/pkg/net/fd_unix.go#newcode39
src/pkg/net/fd_unix.go:39: func dialAround(network string, ra Addr,
dialer func(time.Time) (Conn, error), deadline time.Time) (Conn, error)
{
changed to dial.

https://codereview.appspot.com/12416043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Sep 10, 2013 at 3:42 pm
    I think this should be DualStack, not MultiAttempt. MultiAttempt might just
    as well mean trying multiple addresses in sequence. We should leave a
    separate setting open for when we want to do that (or we might just do it
    by default, as other things do). This weird racing two Dials against each
    other is really specific to IPv6 and Happy Eyeballs (but we can't call the
    bool HappyEyeballs).

    Russ

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikioh Mikioh at Sep 10, 2013 at 9:26 pm
    PTAL

    Changed to DualStack.

    https://codereview.appspot.com/12416043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 10, '13 at 7:43a
activeSep 10, '13 at 9:26p
posts3
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 2 posts Russ Cox: 1 post

People

Translate

site design / logo © 2022 Grokbase