FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
test: fix build (update for new error message)

Please review this at https://codereview.appspot.com/13521044/

Affected files (+2, -2 lines):
    M test/syntax/chan1.go


Index: test/syntax/chan1.go
===================================================================
--- a/test/syntax/chan1.go
+++ b/test/syntax/chan1.go
@@ -10,8 +10,8 @@
   var v int

   func main() {
- if c <- v { // ERROR "send statement.*value.*select"
+ if c <- v { // ERROR "used as value"
    }
   }

-var _ = c <- v // ERROR "send statement.*value.*select"
+var _ = c <- v // ERROR "used as value"


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Rsc at Sep 6, 2013 at 8:15 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=0c02c817d815 ***

    test: fix build (update for new error message)

    R=golang-dev
    CC=golang-dev
    https://codereview.appspot.com/13521044


    https://codereview.appspot.com/13521044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Sep 6, 2013 at 8:24 pm
    LGTM


    On Fri, Sep 6, 2013 at 1:15 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go/


    Description:
    test: fix build (update for new error message)

    Please review this at https://codereview.appspot.**com/13521044/<https://codereview.appspot.com/13521044/>

    Affected files (+2, -2 lines):
    M test/syntax/chan1.go


    Index: test/syntax/chan1.go
    ==============================**==============================**=======
    --- a/test/syntax/chan1.go
    +++ b/test/syntax/chan1.go
    @@ -10,8 +10,8 @@
    var v int

    func main() {
    - if c <- v { // ERROR "send statement.*value.*select"
    + if c <- v { // ERROR "used as value"
    }
    }

    -var _ = c <- v // ERROR "send statement.*value.*select"
    +var _ = c <- v // ERROR "used as value"


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 6, '13 at 8:15p
activeSep 6, '13 at 8:24p
posts3
users2
websitegolang.org

2 users in discussion

Rsc: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase