FAQ
LGTM

A similar change is needed to oracle.vim.

https://codereview.appspot.com/13441043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Damian Gryski at Sep 3, 2013 at 1:39 pm
    Le mardi 3 septembre 2013 14:59:59 UTC+2, David Crawshaw a écrit :
    LGTM

    A similar change is needed to oracle.vim.
       The position computation for oracle.vim also needs to be updated to take
    encodings into account. A similar bug was just patched against my
    vim-godef plugin.


    https://github.com/dgryski/vim-godef/commit/5e52b008c2b33d817cd01c00c7a6cf588e533da0

        Damian

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Adonovan at Sep 3, 2013 at 2:57 pm

    On 2013/09/03 13:39:02, dgryski wrote:

    Le mardi 3 septembre 2013 14:59:59 UTC+2, David Crawshaw a écrit :
    LGTM

    A similar change is needed to oracle.vim.
    The position computation for oracle.vim also needs to be updated to take
    encodings into account. A similar bug was just patched against my
    vim-godef plugin.


    https://github.com/dgryski/vim-godef/commit/5e52b008c2b33d817cd01c00c7a6cf588e533da0

    Can you explain this change to me? Encodings are not relevant when all
    computations are done in byte offsets.

    (Also: who would use a non-UTF-8 encoding for Go source files?)

    https://codereview.appspot.com/13441043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Adonovan at Sep 3, 2013 at 2:59 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=07183b5c385c&repo=tools ***

    go.tools/oracle: change -pos flag syntax from "file pos-pos" to
    file:pos-pos.

    Pro: no shell quotation needed.
    Con: can't be parsed by (the perpetually useless) Scanf.

    R=crawshaw, dgryski
    CC=golang-dev
    https://codereview.appspot.com/13441043


    https://codereview.appspot.com/13441043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedSep 3, '13 at 1:00p
activeSep 3, '13 at 2:59p
posts4
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase