Message:
Hello [email protected] (cc: [email protected]),
I'd like you to review this change to
https://code.google.com/p/go.tools
Description:
go.tools/cmd/oracle: cosmetic tweaks to Emacs.
1. call display-buffer after the postprocessing step to avoid display
glitch.
2. suppress the postprocessing progress message---it's too verbose.
(instead I should just make the postprocessing loop faster)
Please review this at https://codereview.appspot.com/13388044/
Affected files:
M cmd/oracle/oracle.el
Index: cmd/oracle/oracle.el
===================================================================
--- a/cmd/oracle/oracle.el
+++ b/cmd/oracle/oracle.el
@@ -106,10 +106,6 @@
(insert "\n")
(compilation-mode)
(setq compilation-error-screen-columns nil)
- (let ((w (display-buffer (current-buffer))))
- (balance-windows)
- (shrink-window-if-larger-than-buffer w)
- (set-window-point w (point-min)))
;; Hide the file/line info to save space.
;; Replace each with a little widget.
@@ -121,7 +117,7 @@
(while (not (null p))
(let ((np (compilation-next-single-property-change
p 'compilation-message)))
;; TODO(adonovan): this can be verbose in the *Messages*
buffer.
- (message "Post-processing link (%d%%)" (/ (* p 100)
(point-max)))
+ ;; (message "Post-processing link (%d%%)" (/ (* p 100)
(point-max)))
(if np
(when (equal (line-number-at-pos p) (line-number-at-pos
np))
;; np is (typically) the space following ":"; consume it
too.
@@ -129,7 +125,12 @@
(goto-char np)
(insert " ")))
(setq p np)))
- (message nil)))))
+ (message nil))
+
+ (let ((w (display-buffer (current-buffer))))
+ (balance-windows)
+ (shrink-window-if-larger-than-buffer w)
+ (set-window-point w (point-min))))))
(defun go-oracle-callees ()
"Show possible callees of the function call at the current point."
@@ -168,7 +169,7 @@
(interactive)
(go-oracle--run "freevars"))
-(defun go-oracle-channel-peers ()
+(defun go-oracle-peers ()
"Enumerate the set of possible corresponding sends/receives for
this channel receive/send operation."
(interactive)
--
---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
