FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go


Description:
net: a short list of different address family IP addresses for a DNS
registered name

This CL makes resolveInternetAddr return a list of addresses that
contain a pair of different address family IP addresses if possible,
but doesn't contain any API behavioral changes yet. A simple IP
address selection mechanism for Resolve{TCP,UDP,IP}Addr and Dial API
still prefers IPv4.

This is in preparation for TCP connection setup with fast failover on
dual IP stack node as described in RFC 6555.

Update issue 3610
Update issue 5267

Please review this at https://codereview.appspot.com/13374043/

Affected files:
    M src/pkg/net/dialgoogle_test.go
    M src/pkg/net/ipraw_test.go
    M src/pkg/net/ipsock.go
    M src/pkg/net/lookup.go
    M src/pkg/net/tcp_test.go
    M src/pkg/net/udp_test.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Brad Fitzpatrick at Aug 30, 2013 at 2:57 am
    Before I even look at this, I note that the subject line doesn't contain a
    verb.

    The subject line should say what this changes, succinctly. It's hard to do
    that with only a subject.


    On Thu, Aug 29, 2013 at 6:08 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net: a short list of different address family IP addresses for a DNS
    registered name

    This CL makes resolveInternetAddr return a list of addresses that
    contain a pair of different address family IP addresses if possible,
    but doesn't contain any API behavioral changes yet. A simple IP
    address selection mechanism for Resolve{TCP,UDP,IP}Addr and Dial API
    still prefers IPv4.

    This is in preparation for TCP connection setup with fast failover on
    dual IP stack node as described in RFC 6555.

    Update issue 3610
    Update issue 5267

    Please review this at https://codereview.appspot.**com/13374043/<https://codereview.appspot.com/13374043/>

    Affected files:
    M src/pkg/net/dialgoogle_test.go
    M src/pkg/net/ipraw_test.go
    M src/pkg/net/ipsock.go
    M src/pkg/net/lookup.go
    M src/pkg/net/tcp_test.go
    M src/pkg/net/udp_test.go


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikio Hara at Aug 30, 2013 at 3:03 am
    changed to "net: make resolveInternetAddr return a short list of
    IPv4/v6 addresses"
    On Fri, Aug 30, 2013 at 11:57 AM, Brad Fitzpatrick wrote:
    Before I even look at this, I note that the subject line doesn't contain a
    verb.

    The subject line should say what this changes, succinctly. It's hard to do
    that with only a subject.


    On Thu, Aug 29, 2013 at 6:08 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net: a short list of different address family IP addresses for a DNS
    registered name

    This CL makes resolveInternetAddr return a list of addresses that
    contain a pair of different address family IP addresses if possible,
    but doesn't contain any API behavioral changes yet. A simple IP
    address selection mechanism for Resolve{TCP,UDP,IP}Addr and Dial API
    still prefers IPv4.

    This is in preparation for TCP connection setup with fast failover on
    dual IP stack node as described in RFC 6555.

    Update issue 3610
    Update issue 5267

    Please review this at https://codereview.appspot.com/13374043/

    Affected files:
    M src/pkg/net/dialgoogle_test.go
    M src/pkg/net/ipraw_test.go
    M src/pkg/net/ipsock.go
    M src/pkg/net/lookup.go
    M src/pkg/net/tcp_test.go
    M src/pkg/net/udp_test.go



    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Aug 30, 2013 at 3:10 am
    why short?

    I see nothing describing why it's not a long list of addresses.

    drop the word?

    Also, does IPv4/v6 matter?

    Would "net: make resolveInternetAddr return a list of addresses" be
    accurate?



    On Thu, Aug 29, 2013 at 8:03 PM, Mikio Hara wrote:

    changed to "net: make resolveInternetAddr return a short list of
    IPv4/v6 addresses"
    On Fri, Aug 30, 2013 at 11:57 AM, Brad Fitzpatrick wrote:
    Before I even look at this, I note that the subject line doesn't contain a
    verb.

    The subject line should say what this changes, succinctly. It's hard to do
    that with only a subject.


    On Thu, Aug 29, 2013 at 6:08 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    net: a short list of different address family IP addresses for a DNS
    registered name

    This CL makes resolveInternetAddr return a list of addresses that
    contain a pair of different address family IP addresses if possible,
    but doesn't contain any API behavioral changes yet. A simple IP
    address selection mechanism for Resolve{TCP,UDP,IP}Addr and Dial API
    still prefers IPv4.

    This is in preparation for TCP connection setup with fast failover on
    dual IP stack node as described in RFC 6555.

    Update issue 3610
    Update issue 5267

    Please review this at https://codereview.appspot.com/13374043/

    Affected files:
    M src/pkg/net/dialgoogle_test.go
    M src/pkg/net/ipraw_test.go
    M src/pkg/net/ipsock.go
    M src/pkg/net/lookup.go
    M src/pkg/net/tcp_test.go
    M src/pkg/net/udp_test.go



    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send
    an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikio Hara at Aug 30, 2013 at 3:19 am

    On Fri, Aug 30, 2013 at 12:10 PM, Brad Fitzpatrick wrote:

    why short?

    I see nothing describing why it's not a long list of addresses.

    drop the word?

    Also, does IPv4/v6 matter?

    Would "net: make resolveInternetAddr return a list of addresses" be
    accurate?
    yup, it was still vague. I tried to embed something like "it's kinda
    qualified list, it would be not so long even if the target has tons of
    records, so don't worry about it". but yeah, not accurate. thanks,
    will change it.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 30, '13 at 1:08a
activeAug 30, '13 at 3:19a
posts5
users2
websitegolang.org

2 users in discussion

Mikio Hara: 3 posts Brad Fitzpatrick: 2 posts

People

Translate

site design / logo © 2022 Grokbase