FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/oracle: fix build on darwin

diff -u3: the 3 is redundant and an error on darwin; redundant and
unnecessary on linux.

Please review this at https://codereview.appspot.com/13231044/

Affected files:
    M oracle/oracle_test.go


Index: oracle/oracle_test.go
===================================================================
--- a/oracle/oracle_test.go
+++ b/oracle/oracle_test.go
@@ -210,7 +210,7 @@
     }

     // Compare foo.got with foo.golden.
- cmd := exec.Command("/usr/bin/diff", "-u3", golden, got) // assumes POSIX
+ cmd := exec.Command("/usr/bin/diff", "-u", golden, got) // assumes POSIX
     buf := new(bytes.Buffer)
     cmd.Stdout = buf
     if err := cmd.Run(); err != nil {


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Brad Fitzpatrick at Aug 29, 2013 at 4:13 am
    LGTM


    On Wed, Aug 28, 2013 at 9:08 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go.**tools <https://code.google.com/p/go.tools>


    Description:
    go.tools/oracle: fix build on darwin

    diff -u3: the 3 is redundant and an error on darwin; redundant and
    unnecessary on linux.

    Please review this at https://codereview.appspot.**com/13231044/<https://codereview.appspot.com/13231044/>

    Affected files:
    M oracle/oracle_test.go


    Index: oracle/oracle_test.go
    ==============================**==============================**=======
    --- a/oracle/oracle_test.go
    +++ b/oracle/oracle_test.go
    @@ -210,7 +210,7 @@
    }

    // Compare foo.got with foo.golden.
    - cmd := exec.Command("/usr/bin/diff", "-u3", golden, got)
    // assumes POSIX
    + cmd := exec.Command("/usr/bin/diff", "-u", golden, got) //
    assumes POSIX
    buf := new(bytes.Buffer)
    cmd.Stdout = buf
    if err := cmd.Run(); err != nil {


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R at Aug 29, 2013 at 4:31 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=f841df44e459&repo=tools ***

    go.tools/oracle: fix build on darwin

    diff -u3: the 3 is redundant and an error on darwin; redundant and
    unnecessary on linux.

    R=golang-dev, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/13231044


    https://codereview.appspot.com/13231044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 29, '13 at 4:08a
activeAug 29, '13 at 4:31a
posts3
users2
websitegolang.org

2 users in discussion

R: 2 posts Brad Fitzpatrick: 1 post

People

Translate

site design / logo © 2022 Grokbase