FAQ
Sorry for the ton of messages, but I'm kind of discovering independent
"issues" here as I go along in testing.

Don't apologise! These are all good comments---keep 'em coming.

thanks
alan



https://codereview.appspot.com/9502043/diff/46053/cmd/oracle/oracle.el
File cmd/oracle/oracle.el (right):

https://codereview.appspot.com/9502043/diff/46053/cmd/oracle/oracle.el#newcode70
cmd/oracle/oracle.el:70: (defun go-oracle--run (mode)
On 2013/08/22 22:42:48, Dominik Honnef wrote:
You seem to be relying on tab-width to be 8, which isn't the case in many
setups, leading to confusing indentation such as (replicated with spaces):
Interface may contain these concrete types:
Foo, may point to:
complit
I'm not sure if that's a problem inherent to oracle.el or rather
describe.go,
since it also affects other editors, terminals, etc.
Good point. I've fixed this in all places in matters and will avoid it
in future.

https://codereview.appspot.com/9502043/diff/46053/cmd/oracle/oracle.el#newcode134
cmd/oracle/oracle.el:134: (goto-char (point-min))
On 2013/08/22 22:42:48, Dominik Honnef wrote:
You're being confused by the Window Point. The point you're setting in the
buffer does not necessarily match the point that a window is using for that
particular buffer (think two windows displaying the same buffer at two different
positions as one common example of this outside of elisp madness.)
You have two options: Either use goto-char before displaying the
buffer, or use
set-window-point. But you probably should display the buffer at the very end,
anyway.
See
http://www.gnu.org/software/emacs/manual/html_node/elisp/Window-Point.html#Window-Point
for more information.

D'oh. Of course. Fixed.

https://codereview.appspot.com/9502043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 26, '13 at 8:59p
activeAug 26, '13 at 8:59p
posts1
users1
websitegolang.org

1 user in discussion

Adonovan: 1 post

People

Translate

site design / logo © 2022 Grokbase