FAQ
ping

https://codereview.appspot.com/12414043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Bradfitz at Aug 22, 2013 at 1:10 am
    https://codereview.appspot.com/12414043/diff/108001/src/pkg/net/ipsock.go
    File src/pkg/net/ipsock.go (right):

    https://codereview.appspot.com/12414043/diff/108001/src/pkg/net/ipsock.go#newcode92
    src/pkg/net/ipsock.go:92: return nil
    shouldn't this be addrList(nil) so .Addr() on it returns a nil Addr, and
    doesn't crash?

    firstFavoriteAddr doesn't document that it can return nil.

    https://codereview.appspot.com/12414043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikioh Mikioh at Aug 23, 2013 at 12:29 pm
    PTAL


    https://codereview.appspot.com/12414043/diff/108001/src/pkg/net/ipsock.go
    File src/pkg/net/ipsock.go (right):

    https://codereview.appspot.com/12414043/diff/108001/src/pkg/net/ipsock.go#newcode92
    src/pkg/net/ipsock.go:92: return nil
    shouldn't this be addrList(nil) so .Addr() on it returns a nil Addr,
    and doesn't
    crash?
    resolveInternetAddr will take care, so no.
    firstFavoriteAddr doesn't document that it can return nil.
    added doc.

    https://codereview.appspot.com/12414043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikioh Mikioh at Aug 23, 2013 at 9:52 pm
    ping

    https://codereview.appspot.com/12414043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 22, '13 at 12:42a
activeAug 23, '13 at 9:52p
posts4
users2
websitegolang.org

2 users in discussion

Mikioh Mikioh: 3 posts Bradfitz: 1 post

People

Translate

site design / logo © 2022 Grokbase