[golang-dev] code review 12663043: net: separate unix pollster initialization from network... (issue 12663043)

On Thu, Aug 8, 2013 at 1:49 PM, wrote:

Reviewers: dvyukov,

Message:
Hello [email protected] (cc: [email protected]),

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
net: separate unix pollster initialization from network file descriptor
allocation

This is in preparation for runtime-integrated network pollster for BSD
variants.

Update issue 5199

Please review this at https://codereview.appspot.**com/12663043/<https://codereview.appspot.com/12663043/>

Affected files:
M src/pkg/net/fd_poll_unix.go


Index: src/pkg/net/fd_poll_unix.go
==============================**==============================**=======
--- a/src/pkg/net/fd_poll_unix.go
+++ b/src/pkg/net/fd_poll_unix.go
@@ -252,14 +252,23 @@
}

func (pd *pollDesc) Lock() {
+ if pd.pollServer == nil {
+ return
+ }
pd.pollServer.Lock()
}

func (pd *pollDesc) Unlock() {
+ if pd.pollServer == nil {
+ return
+ }
pd.pollServer.Unlock()
}

func (pd *pollDesc) Wakeup() {
+ if pd.pollServer == nil {
+ return
+ }
pd.pollServer.Wakeup()
}

@@ -294,6 +303,9 @@
}

func (pd *pollDesc) Evict() bool {
+ if pd.pollServer == nil {
+ return false
+ }
return pd.pollServer.Evict(pd)
}



--

---You received this message because you are subscribed to the Google
Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%[email protected]>
.
For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
.

On Fri, Aug 9, 2013 at 6:27 AM, Brad Fitzpatrick wrote:

Who is calling these methods when they don't have pollServers?

On Fri, Aug 9, 2013 at 6:41 AM, wrote:

When you switch to runtime netpoll, you will delete fd_poll_unix.go. So
why do we need to modify it now?