FAQ
PTAL

Thanks. All addressed and changed the CL description.
Also please ensure that fd_poll_unix.go still works as well.
FreeBSD is fine.
Looks like other bros. have unrelated troubles but doesn't matter.
Digressions, it seems like we need a bit more file hand-off tests
for FileConn, FIleListener and FilePacketConn.

https://codereview.appspot.com/8608044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Mikioh Mikioh at Aug 6, 2013 at 6:32 am
    And Evict, sidekick of Close.
    On 2013/08/06 03:29:06, mikio wrote:
    PTAL
    Thanks. All addressed and changed the CL description.
    Also please ensure that fd_poll_unix.go still works as well.
    FreeBSD is fine.
    Looks like other bros. have unrelated troubles but doesn't matter.
    Digressions, it seems like we need a bit more file hand-off tests
    for FileConn, FIleListener and FilePacketConn.


    https://codereview.appspot.com/8608044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Alex Brainman at Aug 6, 2013 at 6:56 am
    Perhaps I am missing something here, but why (*netFD).init cannot be
    part of newFD?

    Alex

    https://codereview.appspot.com/8608044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dvyukov at Aug 6, 2013 at 9:03 am

    On 2013/08/06 06:56:58, brainman wrote:
    Perhaps I am missing something here, but why (*netFD).init cannot be part of
    newFD?
    On BSD systems it's necessary to associate fd with kqueue only after
    listen call. This change allows such flexibility.


    https://codereview.appspot.com/8608044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dvyukov at Aug 6, 2013 at 9:04 am
    LGTM

    https://codereview.appspot.com/8608044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Mikioh Mikioh at Aug 6, 2013 at 2:42 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=43e7b87397b6 ***

    net: separate pollster initialization from network file descriptor
    allocation

    Unlike the existing net package own pollster, runtime-integrated
    network pollster on BSD variants, actually kqueue, requires a socket
    that has beed passed to syscall.Listen previously for a stream
    listener.

    This CL separates pollDesc.Init (actually runtime_pollOpen) from newFD
    to allow control of each state of sockets and adds init method to netFD
    instead. Upcoming CLs will rearrange the call order of
    runtime-integrated
    pollster and syscall functions like the following;

    - For dialers that open active connections, runtime_pollOpen will be
        called in between syscall.Bind and syscall.Connect.

    - For stream listeners that open passive stream connections,
        runtime_pollOpen will be called just after syscall.Listen.

    - For datagram listeners that open datagram connections,
        runtime_pollOpen will be called just after syscall.Bind.

    This is in preparation for runtime-integrated network pollster for BSD
    variants.

    Update issue 5199

    R=dvyukov, alex.brainman, minux.ma
    CC=golang-dev
    https://codereview.appspot.com/8608044


    https://codereview.appspot.com/8608044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 6, '13 at 3:29a
activeAug 6, '13 at 2:42p
posts6
users3
websitegolang.org

People

Translate

site design / logo © 2021 Grokbase