FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
build: ignore new zfiles, delete temp goplay binary in run.bash

Please review this at https://codereview.appspot.com/12320045/

Affected files:
    M .hgignore
    M src/run.bash


Index: .hgignore
===================================================================
--- a/.hgignore
+++ b/.hgignore
@@ -43,6 +43,8 @@
   src/pkg/runtime/goc2c
   src/pkg/runtime/mkversion
   src/pkg/runtime/z*
+src/cmd/cgo/zdefaultcc.go
+src/cmd/go/zdefaultcc.go
   src/pkg/unicode/maketables
   src/pkg/*.*/
   test/pass.out
Index: src/run.bash
===================================================================
--- a/src/run.bash
+++ b/src/run.bash
@@ -161,6 +161,7 @@
   echo
   echo '#' ../misc/goplay
   go build ../misc/goplay
+rm -f $GOROOT/src/goplay

   [ "$GOARCH" == arm ] ||
   (xcd ../test/bench/shootout


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Aug 3, 2013 at 1:34 am
    LGTM

    please sort the two new files into place in the hgignore file

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Russ Cox at Aug 3, 2013 at 1:35 am
    also, 'rm -f goplay' should suffice. go build writes to the current
    directory

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Bradfitz at Aug 3, 2013 at 2:14 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=19591dcb81c6 ***

    build: ignore new zfiles, delete temp goplay binary in run.bash

    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/12320045


    https://codereview.appspot.com/12320045/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedAug 2, '13 at 8:26p
activeAug 3, '13 at 2:14a
posts4
users2
websitegolang.org

2 users in discussion

Bradfitz: 2 posts Russ Cox: 2 posts

People

Translate

site design / logo © 2021 Grokbase