FAQ
Reviewers: gri,

Message:
Hello gri@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.tools


Description:
go.tools/ssa: fix an pacakage-level var initialization order bug.

buildDecl was visiting all decls in source order, but the spec
calls for visiting all vars and init() funcs in order, then
all remaining functions. These two passes are now called
buildInit(), buildFuncDecl().

+ Test.

Also:
- Prog.concreteMethods has been merged into Pkg.values.
- Prog.concreteMethod() renamed declaredFunc().
- s/mfunc/obj/ (name cleanup from recent gri CL)

Please review this at https://codereview.appspot.com/12030044/

Affected files:
    M go/types/gcimporter.go
    M ssa/builder.go
    M ssa/create.go
    M ssa/interp/interp_test.go
    M ssa/interp/testdata/ifaceprom.go
    A ssa/interp/testdata/initorder.go
    M ssa/promote.go
    M ssa/source.go
    M ssa/ssa.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJul 29, '13 at 6:13p
activeJul 29, '13 at 6:20p
posts2
users2
websitegolang.org

2 users in discussion

Gri: 1 post Adonovan: 1 post

People

Translate

site design / logo © 2022 Grokbase