FAQ
LGTM


https://codereview.appspot.com/11374044/diff/8001/src/pkg/runtime/panic.c
File src/pkg/runtime/panic.c (right):

https://codereview.appspot.com/11374044/diff/8001/src/pkg/runtime/panic.c#newcode161
src/pkg/runtime/panic.c:161: runtime·deferreturn(uintptr arg0, ...)
please add a comment

https://codereview.appspot.com/11374044/diff/8001/src/pkg/runtime/softfloat_arm.c
File src/pkg/runtime/softfloat_arm.c (right):

https://codereview.appspot.com/11374044/diff/8001/src/pkg/runtime/softfloat_arm.c#newcode581
src/pkg/runtime/softfloat_arm.c:581: runtime·_sfloat2(uint32 *lr, uint32
r0, ...)
the same reason as in deferreturn?
add a short comment as well, this is tricky

https://codereview.appspot.com/11374044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Jul 17, 2013 at 4:43 pm
    I commented both.

    sfloat2 is a different reason: the actual arguments are uint32 r0, uint32
    r1, uint32 r2, and so on, and the author of the code was too lazy to list
    them all and used ... instead.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Russ Cox at Jul 17, 2013 at 4:43 pm
    Or I should say, used nothing instead, but I am adding the ... to make that
    omission explicit.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Rsc at Jul 17, 2013 at 4:53 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=c31a59b119ad ***

    runtime: use new frame argument size information

    With this CL, I believe the runtime always knows
    the frame size during the gc walk. There is no fallback
    to "assume entire stack frame of caller" anymore.

    R=golang-dev, khr, cshapiro, dvyukov
    CC=golang-dev
    https://codereview.appspot.com/11374044


    https://codereview.appspot.com/11374044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJul 17, '13 at 9:17a
activeJul 17, '13 at 4:53p
posts4
users2
websitegolang.org

2 users in discussion

Rsc: 3 posts Dvyukov: 1 post

People

Translate

site design / logo © 2021 Grokbase