FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto/


Description:
go.crypto/ssh/terminal: support Go 1.0.

For those still stuck on Go 1.0.

Please review this at https://codereview.appspot.com/11297043/

Affected files:
    M ssh/terminal/terminal.go


Index: ssh/terminal/terminal.go
===================================================================
--- a/ssh/terminal/terminal.go
+++ b/ssh/terminal/terminal.go
@@ -568,6 +568,8 @@

     t.remainder = t.inBuf[:n+len(t.remainder)]
    }
+
+ panic("unreachable")
   }

   // SetPrompt sets the prompt to be used when reading subsequent lines.


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Jul 15, 2013 at 8:59 pm
    LGTM

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Russ Cox at Jul 15, 2013 at 8:59 pm
    Please put a comment

    panic("unreachable") // for Go 1.0

    so no one removes it later.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Agl at Jul 15, 2013 at 10:01 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=3b780a7120c9&repo=crypto
    ***

    go.crypto/ssh/terminal: support Go 1.0.

    For those still stuck on Go 1.0.

    R=golang-dev, rsc
    CC=golang-dev
    https://codereview.appspot.com/11297043


    https://codereview.appspot.com/11297043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJul 15, '13 at 8:09p
activeJul 15, '13 at 10:01p
posts4
users2
websitegolang.org

2 users in discussion

Russ Cox: 2 posts Agl: 2 posts

People

Translate

site design / logo © 2021 Grokbase