FAQ
Change 1e659829d22a broke the linux-amd64-race build:
http://build.golang.org/log/667948eb3fb0c96ca9240c024bdf96fdf6c4d16c

net/http: fix memory leak in Transport

Fixes issue 5794

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/10747044

http://code.google.com/p/go/source/detail?r=1e659829d22a

$ tail -200 < log
BenchmarkTCP4Persistent-4 5000 47950 ns/op
BenchmarkTCP4PersistentTimeout-4 5000 46868 ns/op
BenchmarkTCP6OneShot-4 1000 193169 ns/op
BenchmarkTCP6OneShotTimeout-4 1000 213108 ns/op
BenchmarkTCP6Persistent-4 2000 59439 ns/op
BenchmarkTCP6PersistentTimeout-4 2000 58859 ns/op
PASS
BenchmarkAppend-4 1000000 156 ns/op
BenchmarkAppend1Byte-4 1000000 110 ns/op
BenchmarkAppend4Bytes-4 1000000 185 ns/op
BenchmarkAppend8Bytes-4 1000000 178 ns/op
BenchmarkAppend16Bytes-4 1000000 194 ns/op
BenchmarkAppend32Bytes-4 ok net 4.509s
    500000 200 ns/op
BenchmarkAppendStr1Byte-4 5000000 51.5 ns/op
BenchmarkAppendStr4Bytes-4 5000000 56.3 ns/op
BenchmarkAppendStr8Bytes-4 PASS
BenchmarkHeaderWriteSubset-4 5000000 58.5 ns/op
BenchmarkAppendStr16Bytes-4 10000 20280 ns/op 0 B/op
0 allocs/op
BenchmarkReadRequestChrome-4 2000 112544 ns/op 5.43 MB/s
1433 B/op 21 allocs/op
BenchmarkReadRequestCurl-4 5000000 64.6 ns/op
BenchmarkAppendStr32Bytes-4 1000000 123 ns/op
BenchmarkAppendSpecialCase-4 5000 48442 ns/op 1.61 MB/s
853 B/op 11 allocs/op
BenchmarkReadRequestApachebench-4 1000000 145 ns/op
BenchmarkSelectUncontended-4 5000 48328 ns/op 1.70 MB/s
853 B/op 11 allocs/op
BenchmarkReadRequestSiege-4 500000 218 ns/op
BenchmarkSelectContended-4 2000 73863 ns/op 2.04 MB/s 945
B/op 15 allocs/op
BenchmarkReadRequestWrk-4 200000 918 ns/op
BenchmarkSelectNonblock-4 10000 24084 ns/op 1.66 MB/s 793
B/op 7 allocs/op
BenchmarkClientServer-4 2000000 85.7 ns/op
BenchmarkChanUncontended-4 500 388389 ns/op 7112 B/op 65
allocs/op
BenchmarkClientServerParallel4-4 1000000 175 ns/op
BenchmarkChanContended-4 500 346050 ns/op 10081 B/op 81
allocs/op
BenchmarkClientServerParallel64-4 200000 1026 ns/op
BenchmarkChanSync-4 100000 1274 ns/op
BenchmarkChanProdCons0-4 200 1121768 ns/op 21602 B/op 117
allocs/op
BenchmarkServer-4 100000 1700 ns/op
BenchmarkChanProdCons10-4 200 667899 ns/op 1920 B/op 18
allocs/op
BenchmarkServerFakeConnNoKeepAlive-4 200000 1111 ns/op
BenchmarkChanProdCons100-4 200000 991 ns/op
BenchmarkChanProdConsWork0-4 500 384289 ns/op 2484 B/op
29 allocs/op
BenchmarkServerFakeConnWithKeepAlive-4 50000 4295 ns/op
BenchmarkChanProdConsWork10-4 2000 179147 ns/op 2184 B/op
24 allocs/op
BenchmarkServerFakeConnWithKeepAliveLite-4 50000 4539 ns/op
BenchmarkChanProdConsWork100-4 2000 153309 ns/op 1023
B/op 9 allocs/op
BenchmarkServerHandlerTypeLen-4 50000 3478 ns/op
BenchmarkChanCreation-4 500000 371 ns/op
BenchmarkChanSem-4 2000 128794 ns/op 1867 B/op 17
allocs/op
BenchmarkServerHandlerNoLen-4 500000 357 ns/op
BenchmarkCallClosure-4 2000 114675 ns/op 1824 B/op 14
allocs/op
BenchmarkServerHandlerNoType-4 1000000 103 ns/op
BenchmarkCallClosure1-4 1000000 159 ns/op
BenchmarkCallClosure2-4 2000 139342 ns/op 1832 B/op 15
allocs/op
BenchmarkServerHandlerNoHeader-4 500000 295 ns/op
BenchmarkCallClosure3-4 2000 109280 ns/op 1023 B/op 9
allocs/op
   1000000 218 ns/op
BenchmarkCallClosure4-4 1000000 289 ns/op
BenchmarkComplex128DivNormal-4 5000000 56.5 ns/op
BenchmarkComplex128DivNisNaN-4 5000000 40.4 ns/op
BenchmarkComplex128DivDisNaN-4 ok net/http 5.433s
   5000000 40.1 ns/op
BenchmarkComplex128DivNisInf-4 5000000 37.4 ns/op
BenchmarkComplex128DivDisInf-4 PASS
   5000000 62.4 ns/op
BenchmarkConvT2ESmall-4 1000000 150 ns/op
BenchmarkConvT2EUintptr-4 1000000 121 ns/op
BenchmarkConvT2ELarge-4 1000000 249 ns/op
BenchmarkConvT2ISmall-4 1000000 146 ns/op
BenchmarkConvT2IUintptr-4 1000000 121 ns/op
BenchmarkConvT2ILarge-4 ok net/http/cgi 1.021s
   1000000 251 ns/op
BenchmarkConvI2E-4 1000000 121 ns/op
BenchmarkConvI2I-4 1000000 143 ns/op
BenchmarkAssertE2T-4 1000000 132 ns/op
BenchmarkAssertE2TLarge-4 1000000 148 ns/op
BenchmarkAssertE2I-4 PASS
   1000000 144 ns/op
BenchmarkAssertI2T-4 1000000 141 ns/op
BenchmarkAssertI2I-4 1000000 144 ns/op
BenchmarkAssertI2E-4 1000000 124 ns/op
BenchmarkAssertE2E-4 1000000 125 ns/op
BenchmarkMalloc8-4 1000000 137 ns/op
BenchmarkMalloc16-4 1000000 146 ns/op
BenchmarkMallocTypeInfo8-4 ok net/http/cookiejar 1.021s
   1000000 164 ns/op
BenchmarkMallocTypeInfo16-4 1000000 156 ns/op
BenchmarkHashStringSpeed-4 1000000 153 ns/op
BenchmarkHashBytesSpeed-4 1000000 142 ns/op
BenchmarkHashInt32Speed-4 1000000 148 ns/op
BenchmarkHashInt64Speed-4 PASS
   1000000 156 ns/op
BenchmarkHashStringArraySpeed-4 500000 463 ns/op
BenchmarkMegMap-4 ok net/http/fcgi 1.023s
PASS
   1000000 203 ns/op
BenchmarkMegOneMap-4 ok net/http/httptest 1.022s
PASS
   1000000 208 ns/op
BenchmarkMegEqMap-4 2000 92637 ns/op
BenchmarkMegEmptyMap-4 ok net/http/httputil 1.021s
? net/http/pprof [no test files]
ok net/mail 1.070s
ok net/rpc 1.933s
ok net/rpc/jsonrpc 1.027s
ok net/smtp 1.021s
ok net/textproto 1.520s
ok net/url 1.243s
ok os 1.016s
ok os/exec 1.022s
ok os/signal 1.016s
ok os/user 1.013s
ok path 1.013s
ok path/filepath 1.014s
ok reflect 1.660s
ok regexp 364.293s
ok regexp/syntax 7.478s
   2000000 85.2 ns/op
BenchmarkSmallStrMap-4 1000000 203 ns/op
BenchmarkMapStringKeysEight_16-4 1000000 207 ns/op
BenchmarkMapStringKeysEight_32-4 1000000 205 ns/op
BenchmarkMapStringKeysEight_64-4 1000000 204 ns/op
BenchmarkMapStringKeysEight_1M-4 1000000 205 ns/op
BenchmarkIntMap-4 1000000 194 ns/op
BenchmarkRepeatedLookupStrMapKey32-4 1000000 179 ns/op
BenchmarkRepeatedLookupStrMapKey1M-4 1000 219458 ns/op
BenchmarkNewEmptyMap-4 1000000 185 ns/op 65 B/op 1
allocs/op
BenchmarkMapIter-4 500000 735 ns/op
BenchmarkMapIterEmpty-4 5000000 60.7 ns/op
BenchmarkMemmove0-4 5000000 47.6 ns/op
BenchmarkMemmove1-4 1000000 256 ns/op 3.89 MB/s
BenchmarkMemmove2-4 1000000 269 ns/op 7.41 MB/s
BenchmarkMemmove3-4 1000000 277 ns/op 10.82 MB/s
BenchmarkMemmove4-4 500000 287 ns/op 13.90 MB/s
BenchmarkMemmove5-4 500000 387 ns/op 12.89 MB/s
BenchmarkMemmove6-4 500000 469 ns/op 12.79 MB/s
BenchmarkMemmove7-4 500000 547 ns/op 12.78 MB/s
BenchmarkMemmove8-4 1000000 265 ns/op 30.08 MB/s
BenchmarkMemmove9-4 1000000 281 ns/op 31.97 MB/s
BenchmarkMemmove10-4 500000 288 ns/op 34.62 MB/s
BenchmarkMemmove11-4 500000 301 ns/op 36.52 MB/s
BenchmarkMemmove12-4 500000 310 ns/op 38.60 MB/s
BenchmarkMemmove13-4 500000 404 ns/op 32.12 MB/s
BenchmarkMemmove14-4 500000 486 ns/op 28.76 MB/s
BenchmarkMemmove15-4 500000 566 ns/op 26.46 MB/s
BenchmarkMemmove16-4 1000000 272 ns/op 58.70 MB/s
BenchmarkMemmove32-4 500000 286 ns/op 111.64 MB/s
BenchmarkMemmove64-4 500000 312 ns/op 204.57 MB/s
BenchmarkMemmove128-4 500000 365 ns/op 349.80 MB/s
BenchmarkMemmove256-4 500000 476 ns/op 537.51 MB/s
BenchmarkMemmove512-4 500000 712 ns/op 718.61 MB/s
BenchmarkMemmove1024-4 200000 1057 ns/op 968.16 MB/s
BenchmarkMemmove2048-4 100000 1810 ns/op 1131.01 MB/s
BenchmarkMemmove4096-4 50000 3454 ns/op 1185.63 MB/s
BenchmarkFinalizer-4 2000000 132 ns/op
BenchmarkFinalizerRun-4 200000 1431 ns/op
BenchmarkStackGrowth-4 200000 962 ns/op
BenchmarkStackGrowthDeep-4 10000 112629 ns/op
BenchmarkSyscall-4 5000000 45.1 ns/op
BenchmarkSyscallWork-4 200000 1013 ns/op
BenchmarkSyscallExcess-4 5000000 39.4 ns/op
BenchmarkSyscallExcessWork-4 200000 1018 ns/op
BenchmarkCreateGoroutines-4 2000 138625 ns/op
BenchmarkCreateGoroutinesParallel-4 5000 34979 ns/op
BenchmarkMatmult-4 1000000 175 ns/op
BenchmarkIfaceCmp100-4 20000 7596 ns/op
BenchmarkIfaceCmpNil100-4 50000 4006 ns/op
BenchmarkDefer-4 1000000 226 ns/op
BenchmarkDefer10-4 1000000 141 ns/op
BenchmarkDeferMany-4 1000000 306 ns/op
BenchmarkCompareStringEqual-4 5000000 43.4 ns/op
BenchmarkCompareStringIdentical-4 5000000 51.1 ns/op
BenchmarkCompareStringSameLength-4 5000000 56.3 ns/op
BenchmarkCompareStringDifferentLength-4 5000000 46.6 ns/op
BenchmarkCompareStringBigUnaligned-4 1000 122852 ns/op 8535.36 MB/s
BenchmarkCompareStringBig-4 2000 104636 ns/op 10021.27 MB/s
ok runtime 32.595s
? runtime/cgo [no test files]
ok runtime/debug 1.052s
? runtime/pprof [no test files]
ok runtime/race 1.031s
ok sort 2.001s
ok strconv 10.740s
ok strings 10.439s
exit status 2
FAIL sync 4.174s
ok sync/atomic 1.015s
ok syscall 1.016s
ok testing 1.013s
? testing/iotest [no test files]
ok testing/quick 1.015s
ok text/scanner 1.013s
ok text/tabwriter 1.014s
ok text/template 1.017s
ok text/template/parse 1.014s
ok time 4.736s
ok unicode 1.013s
ok unicode/utf16 1.015s
ok unicode/utf8 2.121s
? unsafe [no test files]

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 28, '13 at 8:07p
activeJun 28, '13 at 8:07p
posts1
users1
websitegolang.org

1 user in discussion

Builder: 1 post

People

Translate

site design / logo © 2022 Grokbase