FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
crypto/tls: Change TLS version to 1.1 in the package comment.

Also use 2048-bit RSA keys as default in generate_cert.go,
as recommended by the NIST.

Please review this at https://codereview.appspot.com/10676043/

Affected files:
    M src/pkg/crypto/tls/generate_cert.go
    M src/pkg/crypto/tls/tls.go


Index: src/pkg/crypto/tls/generate_cert.go
===================================================================
--- a/src/pkg/crypto/tls/generate_cert.go
+++ b/src/pkg/crypto/tls/generate_cert.go
@@ -30,7 +30,7 @@
    validFrom = flag.String("start-date", "", "Creation date formatted as Jan
1 15:04:05 2011")
    validFor = flag.Duration("duration", 365*24*time.Hour, "Duration that
certificate is valid for")
    isCA = flag.Bool("ca", false, "whether this cert should be its own
Certificate Authority")
- rsaBits = flag.Int("rsa-bits", 1024, "Size of RSA key to generate")
+ rsaBits = flag.Int("rsa-bits", 2048, "Size of RSA key to generate")
   )

   func main() {
Index: src/pkg/crypto/tls/tls.go
===================================================================
--- a/src/pkg/crypto/tls/tls.go
+++ b/src/pkg/crypto/tls/tls.go
@@ -2,7 +2,7 @@
   // Use of this source code is governed by a BSD-style
   // license that can be found in the LICENSE file.

-// Package tls partially implements TLS 1.0, as specified in RFC 2246.
+// Package tls partially implements TLS 1.1, as specified in RFC 4346.
   package tls

   import (


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Jun 27, 2013 at 3:37 pm
    LGTM

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Jun 27, 2013 at 5:42 pm
    sfrithjof, you'll need to submit a CLA for us to accept this.

    See http://golang.org/doc/contribute.html#copyright


    On Thu, Jun 27, 2013 at 2:58 AM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    crypto/tls: Change TLS version to 1.1 in the package comment.

    Also use 2048-bit RSA keys as default in generate_cert.go,
    as recommended by the NIST.

    Please review this at https://codereview.appspot.**com/10676043/<https://codereview.appspot.com/10676043/>

    Affected files:
    M src/pkg/crypto/tls/generate_**cert.go
    M src/pkg/crypto/tls/tls.go


    Index: src/pkg/crypto/tls/generate_**cert.go
    ==============================**==============================**=======
    --- a/src/pkg/crypto/tls/generate_**cert.go
    +++ b/src/pkg/crypto/tls/generate_**cert.go
    @@ -30,7 +30,7 @@
    validFrom = flag.String("start-date", "", "Creation date formatted
    as Jan 1 15:04:05 2011")
    validFor = flag.Duration("duration", 365*24*time.Hour, "Duration
    that certificate is valid for")
    isCA = flag.Bool("ca", false, "whether this cert should be
    its own Certificate Authority")
    - rsaBits = flag.Int("rsa-bits", 1024, "Size of RSA key to
    generate")
    + rsaBits = flag.Int("rsa-bits", 2048, "Size of RSA key to
    generate")
    )

    func main() {
    Index: src/pkg/crypto/tls/tls.go
    ==============================**==============================**=======
    --- a/src/pkg/crypto/tls/tls.go
    +++ b/src/pkg/crypto/tls/tls.go
    @@ -2,7 +2,7 @@
    // Use of this source code is governed by a BSD-style
    // license that can be found in the LICENSE file.

    -// Package tls partially implements TLS 1.0, as specified in RFC 2246.
    +// Package tls partially implements TLS 1.1, as specified in RFC 4346.
    package tls

    import (


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Frithjof Schulze at Jun 27, 2013 at 5:59 pm
    I did this once, but with another email address. Redid it just now with
    this address.
    On Thursday, June 27, 2013 6:42:02 PM UTC+1, Brad Fitzpatrick wrote:

    sfrithjof, you'll need to submit a CLA for us to accept this.

    See http://golang.org/doc/contribute.html#copyright

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Bradfitz at Jun 27, 2013 at 6:24 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=8648a001bbca ***

    crypto/tls: Change TLS version to 1.1 in the package comment.

    Also use 2048-bit RSA keys as default in generate_cert.go,
    as recommended by the NIST.

    R=golang-dev, rsc, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/10676043

    Committer: Brad Fitzpatrick <bradfitz@golang.org>


    https://codereview.appspot.com/10676043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 27, '13 at 2:32p
activeJun 27, '13 at 6:24p
posts5
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase