[golang-dev] code review 10676043: crypto/tls: Change TLS version to 1.1 in the package co... (issue 10676043)

On Thu, Jun 27, 2013 at 2:58 AM, wrote:

Reviewers: golang-dev1,

Message:
Hello [email protected],

I'd like you to review this change to
https://code.google.com/p/go


Description:
crypto/tls: Change TLS version to 1.1 in the package comment.

Also use 2048-bit RSA keys as default in generate_cert.go,
as recommended by the NIST.

Please review this at https://codereview.appspot.**com/10676043/<https://codereview.appspot.com/10676043/>

Affected files:
M src/pkg/crypto/tls/generate_**cert.go
M src/pkg/crypto/tls/tls.go


Index: src/pkg/crypto/tls/generate_**cert.go
==============================**==============================**=======
--- a/src/pkg/crypto/tls/generate_**cert.go
+++ b/src/pkg/crypto/tls/generate_**cert.go
@@ -30,7 +30,7 @@
validFrom = flag.String("start-date", "", "Creation date formatted
as Jan 1 15:04:05 2011")
validFor = flag.Duration("duration", 365*24*time.Hour, "Duration
that certificate is valid for")
isCA = flag.Bool("ca", false, "whether this cert should be
its own Certificate Authority")
- rsaBits = flag.Int("rsa-bits", 1024, "Size of RSA key to
generate")
+ rsaBits = flag.Int("rsa-bits", 2048, "Size of RSA key to
generate")
)

func main() {
Index: src/pkg/crypto/tls/tls.go
==============================**==============================**=======
--- a/src/pkg/crypto/tls/tls.go
+++ b/src/pkg/crypto/tls/tls.go
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

-// Package tls partially implements TLS 1.0, as specified in RFC 2246.
+// Package tls partially implements TLS 1.1, as specified in RFC 4346.
package tls

import (


--

---You received this message because you are subscribed to the Google
Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%[email protected]>
.
For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
.

On Thursday, June 27, 2013 6:42:02 PM UTC+1, Brad Fitzpatrick wrote:

sfrithjof, you'll need to submit a CLA for us to accept this.

See http://golang.org/doc/contribute.html#copyright