FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
crypto/sha1: mark block as non-escaping
The compiler still gets the escape analysis wrong, but the annotation
here is correct.

Please review this at https://codereview.appspot.com/10514046/

Affected files:
    M src/pkg/crypto/sha1/sha1block_decl.go


Index: src/pkg/crypto/sha1/sha1block_decl.go
===================================================================
--- a/src/pkg/crypto/sha1/sha1block_decl.go
+++ b/src/pkg/crypto/sha1/sha1block_decl.go
@@ -6,4 +6,6 @@

   package sha1

+//go:noescape
+
   func block(dig *digest, p []byte)


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Dave Cheney at Jun 25, 2013 at 12:28 am
    LGTM. I'm sure you're already doing so, but please raise a bug for the
    compiler misstep.
    On Tue, Jun 25, 2013 at 10:25 AM, wrote:
    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    crypto/sha1: mark block as non-escaping
    The compiler still gets the escape analysis wrong, but the annotation
    here is correct.

    Please review this at https://codereview.appspot.com/10514046/

    Affected files:
    M src/pkg/crypto/sha1/sha1block_decl.go


    Index: src/pkg/crypto/sha1/sha1block_decl.go
    ===================================================================
    --- a/src/pkg/crypto/sha1/sha1block_decl.go
    +++ b/src/pkg/crypto/sha1/sha1block_decl.go
    @@ -6,4 +6,6 @@

    package sha1

    +//go:noescape
    +
    func block(dig *digest, p []byte)


    --

    ---You received this message because you are subscribed to the Google Groups
    "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Brad Fitzpatrick at Jun 25, 2013 at 12:30 am
    LGTM


    On Mon, Jun 24, 2013 at 5:25 PM, wrote:

    Reviewers: golang-dev1,

    Message:
    Hello golang-dev@googlegroups.com,

    I'd like you to review this change to
    https://code.google.com/p/go


    Description:
    crypto/sha1: mark block as non-escaping
    The compiler still gets the escape analysis wrong, but the annotation
    here is correct.

    Please review this at https://codereview.appspot.**com/10514046/<https://codereview.appspot.com/10514046/>

    Affected files:
    M src/pkg/crypto/sha1/sha1block_**decl.go


    Index: src/pkg/crypto/sha1/sha1block_**decl.go
    ==============================**==============================**=======
    --- a/src/pkg/crypto/sha1/**sha1block_decl.go
    +++ b/src/pkg/crypto/sha1/**sha1block_decl.go
    @@ -6,4 +6,6 @@

    package sha1

    +//go:noescape
    +
    func block(dig *digest, p []byte)


    --

    ---You received this message because you are subscribed to the Google
    Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegroups.com>
    .
    For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
    .

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R at Jun 25, 2013 at 12:48 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=415f87f63234 ***

    crypto/sha1: mark block as non-escaping
    The compiler still gets the escape analysis wrong, but the annotation
    here is correct.

    R=golang-dev, dave, bradfitz
    CC=golang-dev
    https://codereview.appspot.com/10514046


    https://codereview.appspot.com/10514046/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 25, '13 at 12:25a
activeJun 25, '13 at 12:48a
posts4
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase