FAQ
LGTM


https://codereview.appspot.com/10411045/diff/31001/go/types/check.go
File go/types/check.go (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/check.go#newcode26
go/types/check.go:26: // TODO(gri) Decide if this should be a permanent
(always present)
I don't think it should be always-present because this would pin all
ASTs for the entire program for all clients of the SSA IR.

A mode flag sounds good.

https://codereview.appspot.com/10411045/diff/31001/go/types/expr.go
File go/types/expr.go (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/expr.go#newcode1390
go/types/expr.go:1390: if recv := obj.typ.(*Signature).recv; recv != nil
{
This pattern appears three times. Can it be profitably factored?

https://codereview.appspot.com/10411045/diff/31001/go/types/lookup.go
File go/types/lookup.go (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/lookup.go#newcode223
go/types/lookup.go:223: // Otherwise it returns (typ, false).
Document how it differs from typ.Deref().

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/decls3.src
File go/types/testdata/decls3.src (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/decls3.src#newcode93
go/types/testdata/decls3.src:93: P1 /* ERROR "cannot be a pointer" */
What about unsafe.Pointer? Is it subject to the same restriction as
pointer types? The spec is unclear; gc treats it as a basic type.

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/expr3.src
File go/types/testdata/expr3.src (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/expr3.src#newcode109
go/types/testdata/expr3.src:109: _ = T /* ERROR "not in method set" */
.m
Is this test redundant w.r.t L112 or does it verify something more?

Similarly L110 vs L113.

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/methodsets.src
File go/types/testdata/methodsets.src (right):

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/methodsets.src#newcode30
go/types/testdata/methodsets.src:30: _ = T0.v0
Consider asserting the types like so:

var _ func(T0) = T0.v0
...

https://codereview.appspot.com/10411045/diff/31001/go/types/testdata/methodsets.src#newcode33
go/types/testdata/methodsets.src:33: _ = (*T0).v0
What's the identity of the *Func object inferred for this?
Is it the same as T0.v0, or is there a separate object for the
indirection wrapper?

https://codereview.appspot.com/10411045/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 21, '13 at 1:54p
activeJun 21, '13 at 3:57p
posts3
users2
websitegolang.org

2 users in discussion

Gri: 2 posts Adonovan: 1 post

People

Translate

site design / logo © 2021 Grokbase