FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go


Description:
runtime: update runtime·gogo comment in asm files

Please review this at https://codereview.appspot.com/10244043/

Affected files:
    M src/pkg/runtime/asm_386.s
    M src/pkg/runtime/asm_amd64.s
    M src/pkg/runtime/asm_arm.s


Index: src/pkg/runtime/asm_386.s
===================================================================
--- a/src/pkg/runtime/asm_386.s
+++ b/src/pkg/runtime/asm_386.s
@@ -141,7 +141,7 @@
    MOVL BX, gobuf_g(AX)
    RET

-// void gogo(Gobuf*, uintptr)
+// void gogo(Gobuf*)
   // restore state from Gobuf; longjmp
   TEXT runtime·gogo(SB), 7, $0
    MOVL 4(SP), BX // gobuf
Index: src/pkg/runtime/asm_amd64.s
===================================================================
--- a/src/pkg/runtime/asm_amd64.s
+++ b/src/pkg/runtime/asm_amd64.s
@@ -128,7 +128,7 @@
    MOVQ BX, gobuf_g(AX)
    RET

-// void gogo(Gobuf*, uintptr)
+// void gogo(Gobuf*)
   // restore state from Gobuf; longjmp
   TEXT runtime·gogo(SB), 7, $0
    MOVQ 8(SP), BX // gobuf
Index: src/pkg/runtime/asm_arm.s
===================================================================
--- a/src/pkg/runtime/asm_arm.s
+++ b/src/pkg/runtime/asm_arm.s
@@ -108,7 +108,7 @@
    MOVW R11, gobuf_ctxt(R0)
    RET

-// void gogo(Gobuf*, uintptr)
+// void gogo(Gobuf*)
   // restore state from Gobuf; longjmp
   TEXT runtime·gogo(SB), 7, $-4
    MOVW 0(FP), R1 // gobuf


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Minux at Jun 12, 2013 at 9:53 pm
    LGTM.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Iant at Jun 12, 2013 at 10:05 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=8519983c00e8 ***

    runtime: update runtime·gogo comment in asm files

    R=golang-dev, minux.ma
    CC=golang-dev
    https://codereview.appspot.com/10244043


    https://codereview.appspot.com/10244043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 12, '13 at 9:46p
activeJun 12, '13 at 10:05p
posts3
users2
websitegolang.org

2 users in discussion

Iant: 2 posts Minux: 1 post

People

Translate

site design / logo © 2021 Grokbase