FAQ
LGTM with one suggestion you can put in if you want.


https://codereview.appspot.com/8601044/diff/9001/src/cmd/gc/sinit.c
File src/cmd/gc/sinit.c (right):

https://codereview.appspot.com/8601044/diff/9001/src/cmd/gc/sinit.c#newcode56
src/cmd/gc/sinit.c:56: break;
If we put the right class on declarations of _, then we can get rid of
this horrible hack.

It's a one line change in src/cmd/gc/dcl.c:196

https://codereview.appspot.com/8601044/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Russ Cox at Jun 11, 2013 at 6:53 pm
    Let's keep the declaration class for now, please. I don't know what else
    would break if we did that, and I'm not comfortable finding out in Go 1.1.1.
    But feel free to send a follow-up CL, that would not be part of Go 1.1.1,
    with that simplification, if it does work.

    Russ

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Remyoudompheng at Jun 11, 2013 at 8:22 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=3a74e15c5d56 ***

    cmd/gc: compute initialization order for top-level blank vars too.

    Fixes issue 5244.

    R=golang-dev, rsc, iant, r, daniel.morsing
    CC=golang-dev
    https://codereview.appspot.com/8601044


    https://codereview.appspot.com/8601044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 11, '13 at 6:40p
activeJun 11, '13 at 8:22p
posts3
users3
websitegolang.org

People

Translate

site design / logo © 2022 Grokbase