FAQ
Thank you for your review. I've made the changes you requested and added
some more words to try to describe the problem they are solving.


https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):

https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go#newcode154
ssh/test/test_unix_test.go:154: sysref int
On 2013/06/04 16:53:53, agl1 wrote:
Comment for sysref? What it does is not clear from the name.
sysRefCount?
This code (and the support functions below) were cribbed from the net
package directly, their naming is mostly historical.

https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go#newcode166
ssh/test/test_unix_test.go:166: func (c *client) incref(closing bool)
error {
On 2013/06/04 16:53:53, agl1 wrote:
incRef?
Done.

https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go#newcode173
ssh/test/test_unix_test.go:173: if closing {
On 2013/06/04 16:53:53, agl1 wrote:
could be just c.closing = closing.
This check is needed so that c.closing does not fall back to false.

https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go#newcode179
ssh/test/test_unix_test.go:179: func (c *client) decref() {
On 2013/06/04 16:53:53, agl1 wrote:
decRef?
Done.

https://codereview.appspot.com/9929043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Dave at Jun 5, 2013 at 1:19 am
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=553b87316697&repo=crypto
    ***

    go.crypto/ssh: fix race on mock ssh network connection

    Fixes issue 5138.
    Fixes issue 4703.

    This appears to pass my stress tests with and without the -race
    detector, but I'd like to see others hit it with their machines.

    R=golang-dev, fullung, huin, kardianos, agl
    CC=golang-dev
    https://codereview.appspot.com/9929043


    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Agl at Jun 5, 2013 at 1:46 am
    https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go
    File ssh/test/test_unix_test.go (right):

    https://codereview.appspot.com/9929043/diff/23001/ssh/test/test_unix_test.go#newcode173
    ssh/test/test_unix_test.go:173: if closing {
    On 2013/06/05 01:19:00, dfc wrote:
    On 2013/06/04 16:53:53, agl1 wrote:
    could be just c.closing = closing.
    This check is needed so that c.closing does not fall back to false.
    Unimportant, but we know that c.closing is false because, if it were
    true, then we would return on line 170.

    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 5, '13 at 1:19a
activeJun 5, '13 at 1:46a
posts3
users2
websitegolang.org

2 users in discussion

Dave: 2 posts Agl: 1 post

People

Translate

site design / logo © 2021 Grokbase