FAQ
Reviewers: r,

Message:
Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/


Description:
image/jpeg: avoid documentation argument over whether it's luma
subsampling or chroma subsampling.

Fixes issue 5569.

Please review this at https://codereview.appspot.com/9900044/

Affected files:
    M src/pkg/image/jpeg/reader.go


Index: src/pkg/image/jpeg/reader.go
===================================================================
--- a/src/pkg/image/jpeg/reader.go
+++ b/src/pkg/image/jpeg/reader.go
@@ -174,10 +174,10 @@
     // values for the Cr and Cb components must be (1, 1).
     if i == 0 {
      if hv != 0x11 && hv != 0x21 && hv != 0x22 && hv != 0x12 {
- return UnsupportedError("luma downsample ratio")
+ return UnsupportedError("luma/chroma downsample ratio")
      }
     } else if hv != 0x11 {
- return UnsupportedError("chroma downsample ratio")
+ return UnsupportedError("luma/chroma downsample ratio")
     }
    }
    return nil


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R at Jun 4, 2013 at 10:30 am
    LGTM

    https://codereview.appspot.com/9900044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 4, '13 at 6:55a
activeJun 4, '13 at 10:30a
posts2
users2
websitegolang.org

2 users in discussion

R: 1 post Nigeltao: 1 post

People

Translate

site design / logo © 2022 Grokbase