FAQ
Just the one question, although I'm not familiar with this section of
the code, so I can't add much of value in reviewing changes here.


https://codereview.appspot.com/9929043/diff/13001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (left):

https://codereview.appspot.com/9929043/diff/13001/ssh/test/test_unix_test.go#oldcode157
ssh/test/test_unix_test.go:157: // newServer returns a new mock ssh
server.
Was this comment deliberately deleted?

https://codereview.appspot.com/9929043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Fullung at Jun 3, 2013 at 8:09 am
    Hello
    On 2013/06/02 01:45:52, dfc wrote:
    On 2013/06/01 06:59:43, dfc wrote:
    s.cmd.Wait()
    That was incorporated into s.Shutdown by dsymonds a while back.
    Please
    let me know if I am missing something.
    Gentle ping. It is entirely my fault that these tests have been broken for so
    long, so now that I have some time, i'd like to rectify this.
    This still seems to leak processes.

    If you run with -test.cpu=1,1,1,1,1,1,1,...

    pstree -l | grep test

    shows a bunch of sshd processes accumulating.

    Other than that, looks good to me.

    Also: Fixes issue 4703.

    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave at Jun 3, 2013 at 8:43 am

    This still seems to leak processes.
    If you run with -test.cpu=1,1,1,1,1,1,1,...
    pstree -l | grep test
    I cannot reproduce this result, I can see a possible thread leak, which
    I am not concerned about at this time

    lucky(~) % pstree -l | grep test
    -bash---go-+-test.test---32*[{test.test}]
    Other than that, looks good to me.
    Could you please use the magic letters :)

    Also: Fixes issue 4703.
    Done

    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave at Jun 3, 2013 at 8:43 am
    Hello golang-dev@googlegroups.com, fullung@gmail.com, huin@google.com,
    kardianos@gmail.com (cc: golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Dave at Jun 3, 2013 at 8:43 am
    https://codereview.appspot.com/9929043/diff/13001/ssh/test/test_unix_test.go
    File ssh/test/test_unix_test.go (left):

    https://codereview.appspot.com/9929043/diff/13001/ssh/test/test_unix_test.go#oldcode157
    ssh/test/test_unix_test.go:157: // newServer returns a new mock ssh
    server.
    On 2013/06/03 07:59:56, huin-google wrote:
    Was this comment deliberately deleted?
    Good catch, I was working a lot in this area and deleted the comment by
    accident.

    https://codereview.appspot.com/9929043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedJun 3, '13 at 7:59a
activeJun 3, '13 at 8:43a
posts5
users3
websitegolang.org

3 users in discussion

Dave: 3 posts Huin: 1 post Fullung: 1 post

People

Translate

site design / logo © 2021 Grokbase