FAQ
Does anyone make use of Mercurial patch queues and the go codereview
extension? Out of the box, these extensions seem to conflict. Perhaps
someone has found a way around that?

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Daniel Morsing at May 29, 2013 at 6:22 am

    On Wed, May 29, 2013 at 3:12 AM, Carl Shapiro wrote:
    Does anyone make use of Mercurial patch queues and the go codereview
    extension? Out of the box, these extensions seem to conflict. Perhaps
    someone has found a way around that?
    https://code.google.com/p/go/issues/detail?id=3716

    I have given up using codereview for local management of patches. I
    just have 2 repositories, one without codereview that I do my work in
    and another with codereview that I apply patches on to send out
    patches and submit them.
    --

    ---
    You received this message because you are subscribed to the Google Groups
    "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an
    email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Carl Shapiro at May 30, 2013 at 5:27 am

    On Tue, May 28, 2013 at 11:22 PM, Daniel Morsing wrote:

    I have given up using codereview for local management of patches. I
    just have 2 repositories, one without codereview that I do my work in
    and another with codereview that I apply patches on to send out
    patches and submit them.
    Interesting. Do you do anything special to move changes from one
    repository to another? Ideally, I would like to have one $GOROOT and one
    go in my $PATH to avoid accidentally testing the wrong binary. If you have
    a clever way to move a change from one repository to the other for the sake
    of doing the review, you scheme might be the next best thing.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Daniel Morsing at May 30, 2013 at 6:23 am

    On Thu, May 30, 2013 at 7:26 AM, Carl Shapiro wrote:
    On Tue, May 28, 2013 at 11:22 PM, Daniel Morsing wrote:

    I have given up using codereview for local management of patches. I
    just have 2 repositories, one without codereview that I do my work in
    and another with codereview that I apply patches on to send out
    patches and submit them.

    Interesting. Do you do anything special to move changes from one repository
    to another? Ideally, I would like to have one $GOROOT and one go in my
    $PATH to avoid accidentally testing the wrong binary. If you have a clever
    way to move a change from one repository to the other for the sake of doing
    the review, you scheme might be the next best thing.
    Not really, it's just applying hg diff onto my outgoing repo.

    You shouldn't need to set GOROOT unless you're using the binary
    distribution. The build system will embed GOROOT into the binaries and
    the go tool will automatically choose the compilers, tools and GOROOT
    depending on where it was compiled. In order to switch between the 2
    versions, it's really just a matter of creating symlinks to the
    various go tool binaries in your trees. For example, I have
    ~/src/go/bin in my PATH and a symlink called ~/bin/godev, pointing at
    ~/src/godev/bin/go.

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMay 29, '13 at 1:12a
activeMay 30, '13 at 6:23a
posts4
users2
websitegolang.org

2 users in discussion

Carl Shapiro: 2 posts Daniel Morsing: 2 posts

People

Translate

site design / logo © 2022 Grokbase