FAQ
Have you signed the CLA? http://golang.org/doc/contribute.html#copyright

I altered the code to be compatible with OpenSSL's PSS implementation.
This required adding a PSSOptions struct argument to VerifyPSS and
SignPSS. Please see http://play.golang.org/p/pxYrCq1VBj.

I also altered the tests to check all the values of NIST's test vectors
(from a testdata file) and to check OpenSSL compat. Please see
http://play.golang.org/p/qEYe_ieyd-

https://codereview.appspot.com/9438043/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Monnand at May 22, 2013 at 8:52 pm

    On 2013/05/22 20:21:02, agl1 wrote:
    Have you signed the CLA?
    http://golang.org/doc/contribute.html#copyright


    Just signed it. It said that it will be processed shortly.
    I altered the code to be compatible with OpenSSL's PSS implementation. This
    required adding a PSSOptions struct argument to VerifyPSS and SignPSS. Please
    see http://play.golang.org/p/pxYrCq1VBj.
    I also altered the tests to check all the values of NIST's test
    vectors (from a
    testdata file) and to check OpenSSL compat. Please see
    http://play.golang.org/p/qEYe_ieyd-
    Sure. Do I need to copy those code and upload another patch set to this
    CL?


    https://codereview.appspot.com/9438043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Adam Langley at May 22, 2013 at 8:56 pm

    On Wed, May 22, 2013 at 4:52 PM, wrote:
    Just signed it. It said that it will be processed shortly.
    Thanks. I'll do the A+C update for you.
    Sure. Do I need to copy those code and upload another patch set to this
    CL?
    Nope, if you're happy with it then you don't need to update the CL.
    I'll land from my local copy.


    Cheers

    AGL

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Monnand at May 22, 2013 at 9:17 pm

    On 2013/05/22 20:56:39, agl wrote:
    On Wed, May 22, 2013 at 4:52 PM, wrote:
    Just signed it. It said that it will be processed shortly.
    Thanks. I'll do the A+C update for you.

    Thank you!
    Sure. Do I need to copy those code and upload another patch set to
    this
    CL?
    Nope, if you're happy with it then you don't need to update the CL.
    I'll land from my local copy.

    Sure. I'm happy with it. It looks better.
    Cheers
    AGL


    https://codereview.appspot.com/9438043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMay 22, '13 at 8:21p
activeMay 22, '13 at 9:17p
posts4
users3
websitegolang.org

3 users in discussion

Monnand: 2 posts Adam Langley: 1 post Agl: 1 post

People

Translate

site design / logo © 2022 Grokbase