FAQ
https://codereview.appspot.com/9303048/diff/6016/go/types/types.go
File go/types/types.go (right):

https://codereview.appspot.com/9303048/diff/6016/go/types/types.go#newcode12
go/types/types.go:12: // Underlying returns the underlying type of a
type.
Explain what this means?

https://codereview.appspot.com/9303048/diff/6016/go/types/types.go#newcode15
go/types/types.go:15: // For a pointer type (or a named type denoting a
pointer type),
"denoting" isn't a spec word. Is "whose underlying type is a pointer"
too verbose?

https://codereview.appspot.com/9303048/diff/6016/go/types/types.go#newcode25
go/types/types.go:25: // and some others. What is the design principle?
Prefer not to add methods if they could in principle be external. Also,
avoid predicates like IsIdentical to avoid the binary method problem.

https://codereview.appspot.com/9303048/diff/6016/go/types/types.go#newcode218
go/types/types.go:218: // TODO(gri): Do we keep ForEach or should we
abandon it in favor or Len and At?
I say abandon, for now.

https://codereview.appspot.com/9303048/diff/6016/go/types/types.go#newcode287
go/types/types.go:287: type Builtin struct {
Thanks!

https://codereview.appspot.com/9303048/diff/6016/ssa/util.go
File ssa/util.go (right):

https://codereview.appspot.com/9303048/diff/6016/ssa/util.go#newcode49
ssa/util.go:49: func underlyingType(typ types.Type) types.Type {
You could delete this if you like. Or leave that for me.
Ditto indirect() and deref() below.

https://codereview.appspot.com/9303048/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMay 16, '13 at 5:04p
activeMay 17, '13 at 5:09a
posts5
users2
websitegolang.org

2 users in discussion

Adonovan: 3 posts Gri: 2 posts

People

Translate

site design / logo © 2021 Grokbase