FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com (cc: agl@golang.org),

I'd like you to review this change to
https://code.google.com/p/go


Description:
rsa: Implementation of RSASSA-PSS signature algorithm and its
corresponding test cases

Implementation of RSASSA-PSS signature algorithm described in RFC 3447
and its corresponding test cases.

There are two test files:
- emsa_test.go: Test on EMSA-PSS encoding/decoding scheme
- pssvect_test.go: Test on the signature algorithm itself. All cases are
generated from the test vectors provided by RSA Lab, which can be
downloaded from
ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-1/pkcs-1v2-1-vec.zip

Please review this at https://codereview.appspot.com/9438043/

Affected files:
    A src/pkg/crypto/rsa/emsa_test.go
    A src/pkg/crypto/rsa/pss.go
    A src/pkg/crypto/rsa/pssvect_test.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R at May 15, 2013 at 10:04 pm
    Does this need to be in the main repo? The go.crypt repo seems fine to
    ignorant me.


    https://codereview.appspot.com/9438043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Monnand at May 15, 2013 at 10:14 pm
    In rsa.go, line 8, there is a TODO says " TODO(agl): Add support for PSS
    padding." So I submit this CL to the main repo.

    To me, putting these functions to anywhere would be OK. Do I need to
    submit another CL to go.crypto repo?
    On 2013/05/15 22:04:02, r wrote:
    Does this need to be in the main repo? The go.crypt repo seems fine to ignorant
    me.


    https://codereview.appspot.com/9438043/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMay 15, '13 at 10:01p
activeMay 15, '13 at 10:14p
posts3
users2
websitegolang.org

2 users in discussion

Monnand: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase