FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/


Description:
cmd/api: don't print out except.txt removed features to stdout

It's just noise. They've already been acknowledged in except.txt.

Please review this at https://codereview.appspot.com/9392047/

Affected files:
    M src/cmd/api/goapi.go


Index: src/cmd/api/goapi.go
===================================================================
--- a/src/cmd/api/goapi.go
+++ b/src/cmd/api/goapi.go
@@ -231,7 +231,12 @@
     case len(features) == 0 || (len(required) > 0 && required[0] <
features[0]):
      feature := take(&required)
      if exceptionSet[feature] {
- fmt.Fprintf(w, "~%s\n", feature)
+ // An "unfortunate" case: the feature was once
+ // included in the API (e.g. go1.txt), but was
+ // subsequently removed. These are already
+ // acknowledged by being in the file
+ // "api/except.txt". No need to print them out
+ // here.
      } else if featureSet[featureWithoutContext(feature)] {
       // okay.
      } else {


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • R at May 14, 2013 at 4:36 pm
    LGTM

    https://codereview.appspot.com/9392047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Bradfitz at May 14, 2013 at 4:44 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=ae5e57336939 ***

    cmd/api: don't print out except.txt removed features to stdout

    It's just noise. They've already been acknowledged in except.txt.

    R=golang-dev, r
    CC=golang-dev
    https://codereview.appspot.com/9392047


    https://codereview.appspot.com/9392047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedMay 14, '13 at 4:34p
activeMay 14, '13 at 4:44p
posts3
users2
websitegolang.org

2 users in discussion

Bradfitz: 2 posts R: 1 post

People

Translate

site design / logo © 2022 Grokbase