FAQ
I think you made mistake with pointers. Your NetGetJoinInformation call
always fails with "The parameter is incorrect" error. I moved all
windows api prototypes into syscall
http://code.google.com/p/go/issues/detail?id=5298#c5 (like we always
do), and that helped to clear the issue. Please, accept my changes.

Alex


https://codereview.appspot.com/8541047/diff/27001/src/pkg/os/user/lookup_windows.go
File src/pkg/os/user/lookup_windows.go (right):

https://codereview.appspot.com/8541047/diff/27001/src/pkg/os/user/lookup_windows.go#newcode61
src/pkg/os/user/lookup_windows.go:61: // pretend username is fullname
This comment is misleading now. pc is not part of any domain, if we are
here.

https://codereview.appspot.com/8541047/diff/27001/src/pkg/os/user/lookup_windows.go#newcode116
src/pkg/os/user/lookup_windows.go:116: defer t.Close()
Good catch.

https://codereview.appspot.com/8541047/

--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Snaury at Apr 23, 2013 at 5:40 am
    Hello golang-dev@googlegroups.com, bradfitz@golang.org,
    alex.brainman@gmail.com, lucio.dere@gmail.com (cc:
    golang-dev@googlegroups.com),

    Please take another look.


    https://codereview.appspot.com/8541047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Snaury at Apr 23, 2013 at 5:43 am

    On 2013/04/23 00:59:25, brainman wrote:
    Please, accept my changes. Done.
    pc is not part of any domain, if we are here.
    Not necessarily. If computer is part of a domain this code is tried as
    well (just like before). But comment was misplaced, so I fixed it this
    time.
    Good catch.
    Was looking for leaks in my changes, found a token leak instead. %)

    https://codereview.appspot.com/8541047/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedApr 23, '13 at 12:59a
activeApr 23, '13 at 5:43a
posts3
users2
websitegolang.org

2 users in discussion

Snaury: 2 posts Alex Brainman: 1 post

People

Translate

site design / logo © 2022 Grokbase