FAQ
Reviewers: golang-dev1,

Message:
Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/


Description:
encoding/json: different decision on tags and shadowing
If there are no tags, the rules are the same as before.
If there is a tagged field, choose it if there is exactly one
at the top level of all fields.
More tests. The old tests were clearly inadequate, since
they all pass as is. The new tests only work with the new code.

Please review this at https://codereview.appspot.com/8617044/

Affected files:
M src/pkg/encoding/json/encode.go
M src/pkg/encoding/json/encode_test.go


--

---
You received this message because you are subscribed to the Google Groups "golang-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Search Discussions

  • Iant at Apr 10, 2013 at 7:22 pm
    LGTM

    This seems like a reasonable semantic, and the code looks fine.

    Can we improve the docs?

    https://codereview.appspot.com/8617044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • Rob Pike at Apr 10, 2013 at 7:24 pm
    I will work on docs once we decide on the design. Does anyone else
    here want to comment on the approach?

    -rob

    On Wed, Apr 10, 2013 at 12:22 PM, wrote:
    LGTM

    This seems like a reasonable semantic, and the code looks fine.

    Can we improve the docs?

    https://codereview.appspot.com/8617044/
    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.
  • R at Apr 10, 2013 at 8:05 pm
    *** Submitted as
    https://code.google.com/p/go/source/detail?r=848d7e249632 ***

    encoding/json: different decision on tags and shadowing
    If there are no tags, the rules are the same as before.
    If there is a tagged field, choose it if there is exactly one
    at the top level of all fields.
    More tests. The old tests were clearly inadequate, since
    they all pass as is. The new tests only work with the new code.

    R=golang-dev, iant
    CC=golang-dev
    https://codereview.appspot.com/8617044


    https://codereview.appspot.com/8617044/

    --

    ---
    You received this message because you are subscribed to the Google Groups "golang-dev" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
    For more options, visit https://groups.google.com/groups/opt_out.

Related Discussions

Discussion Navigation
viewthread | post
Discussion Overview
groupgolang-dev @
categoriesgo
postedApr 10, '13 at 7:12p
activeApr 10, '13 at 8:05p
posts4
users2
websitegolang.org

2 users in discussion

R: 3 posts Iant: 1 post

People

Translate

site design / logo © 2022 Grokbase